git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* A little help understanding output from git blame --reverse
@ 2017-02-06 12:38 Edmundo Carmona Antoranz
  2017-02-06 12:40 ` Edmundo Carmona Antoranz
  0 siblings, 1 reply; 2+ messages in thread
From: Edmundo Carmona Antoranz @ 2017-02-06 12:38 UTC (permalink / raw)
  To: Git List

Hi!

While doing some research developing difflame I found some output from
git blame --reverse that I can't quite understand. Perhaps another set
of eyeballs could help me.

I'm "difflaming" HEAD~100 (02db2d0421b97fcb6211) and HEAD
(066fb0494e6398eb). Specifically file abspath.c.

If we diff (as in plain old git diff) HEAD~100..HEAD we can see that
line 63 (from HEAD~100 revision) was deleted between HEAD~100 and
HEAD:

@@ -58,86 +95,136 @@ blah blah
                       goto error_out;
       }

-       strbuf_reset(&sb);
-       strbuf_addstr(&sb, path);
-
-       while (depth--) {
-               if (!is_directory(sb.buf)) {


So, if I do a "reverse" blame operation on the file, I would expect to
see the last revision where that line was _present_ on the file:

c5f3cba126  61)         strbuf_reset(&sb);
c5f3cba126  62)         strbuf_addstr(&sb, path);
066fb0494e  63)
c5f3cba126  64)         while (depth--) {
c5f3cba126  65)                 if (!is_directory(sb.buf)) {

line 63 shows up as if it had been last present on the file on
revision 066fb0494e, which is HEAD, which kind of doesn't make a lot
of sense to me because given that the line is not present on the file
on HEAD (as we can guess from diff output) it means it was "forcefully
present" on some previous revision (and that's what I would expect to
see reported on blame --reverse output).

What am I missing? Thanks in advance.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: A little help understanding output from git blame --reverse
  2017-02-06 12:38 A little help understanding output from git blame --reverse Edmundo Carmona Antoranz
@ 2017-02-06 12:40 ` Edmundo Carmona Antoranz
  0 siblings, 0 replies; 2+ messages in thread
From: Edmundo Carmona Antoranz @ 2017-02-06 12:40 UTC (permalink / raw)
  To: Git List

On Mon, Feb 6, 2017 at 6:38 AM, Edmundo Carmona Antoranz
<eantoranz@gmail.com> wrote:
> I'm "difflaming" HEAD~100 (02db2d0421b97fcb6211) and HEAD
> (066fb0494e6398eb). Specifically file abspath.c.

I just noticed that I'm standing on a private branch. Replace HEAD for
"4e59582ff" when doing your analysis. You should get the same results.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-06 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 12:38 A little help understanding output from git blame --reverse Edmundo Carmona Antoranz
2017-02-06 12:40 ` Edmundo Carmona Antoranz

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).