From: Karthik Nayak <karthik.188@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v4 02/10] ref-filter: make the 'color' use ref_formatting_state
Date: Sun, 26 Jul 2015 11:10:10 +0530 [thread overview]
Message-ID: <CAOLa=ZRz9LL5heW2FOhZje+=5W_Ybtm+Rcsm-RH=eKXoh5yw2Q@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cQEKrjePskjSacrf3SbLZR7_ADxTLwcV7vBPcjUxBLiEg@mail.gmail.com>
On Sun, Jul 26, 2015 at 9:42 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> Should 'color' should be declared 'char *' rather than 'const char *'?
> It's always assigned via xstrdup(), and if declared 'char *', you
> wouldn't have to cast away the 'const' when freeing it.
>
yes, will change.
>
> While reviewing patch 1/10, it required more effort and was
> distracting to have to separate out (mentally) changes which were
> specific to the new %(align:X) pseudo-atom and those which introduced
> the "formatting state". As such, it probably would be a good idea to
> aim for the three distinct patches suggested by Junio rather than
> aiming, up front, to merge the first two. After all, they are
> conceptually distinct changes, and keeping them separate is friendlier
> to reviewers. In the end, you may find that patch 1 is so trivial that
> it can be merged with patch 2 without making review more difficult,
> however, keeping them distinct during development helps you avoid
> conflating unrelated changes.
>
Yes! I'm doing that like Junio suggested. Thanks for bringing it up :)
--
Regards,
Karthik Nayak
next prev parent reply other threads:[~2015-07-26 5:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 19:04 [PATCH v4 0/10] port tag.c to use ref-filter APIs Karthik Nayak
2015-07-24 19:04 ` [PATCH v4 01/10] ref-filter: add option to align atoms to the left Karthik Nayak
2015-07-24 21:54 ` Junio C Hamano
2015-07-24 23:00 ` Junio C Hamano
2015-07-25 4:14 ` Karthik Nayak
2015-07-26 4:08 ` Eric Sunshine
2015-07-26 4:36 ` Karthik Nayak
2015-07-26 5:58 ` Eric Sunshine
2015-07-26 6:03 ` Karthik Nayak
2015-07-27 12:01 ` Matthieu Moy
2015-07-27 0:39 ` Duy Nguyen
2015-07-27 7:39 ` Jacob Keller
2015-07-27 10:18 ` Duy Nguyen
2015-07-28 10:35 ` Duy Nguyen
2015-07-24 19:04 ` [PATCH v4 02/10] ref-filter: make the 'color' use ref_formatting_state Karthik Nayak
2015-07-24 21:46 ` Junio C Hamano
2015-07-25 4:15 ` Karthik Nayak
2015-07-26 4:28 ` Eric Sunshine
2015-07-26 4:12 ` Eric Sunshine
2015-07-26 5:40 ` Karthik Nayak [this message]
2015-07-24 19:04 ` [PATCH v4 03/10] ref-filter: add option to filter only tags Karthik Nayak
2015-07-24 19:04 ` [PATCH v4 04/10] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-26 4:46 ` Eric Sunshine
2015-07-26 5:15 ` Karthik Nayak
2015-07-24 19:04 ` [PATCH v4 05/10] ref-filter: add support to sort by version Karthik Nayak
2015-07-25 22:40 ` Junio C Hamano
2015-07-26 5:07 ` Karthik Nayak
2015-07-27 15:24 ` Junio C Hamano
2015-07-27 17:03 ` Karthik Nayak
2015-07-24 19:04 ` [PATCH v4 06/10] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-26 5:15 ` Eric Sunshine
2015-07-26 18:21 ` Karthik Nayak
2015-07-24 19:04 ` [PATCH v4 07/10] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-24 19:19 ` [PATCH v4 08/10] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-24 19:19 ` [PATCH v4 09/10] tag.c: implement '--format' option Karthik Nayak
2015-07-24 19:19 ` [PATCH v4 10/10] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZRz9LL5heW2FOhZje+=5W_Ybtm+Rcsm-RH=eKXoh5yw2Q@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).