Re: [PATCH v4 04/10] ref-filter: support printing N lines from tag annotation

[Karthik Nayak <karthik.188@gmail.com>]

On Sun, Jul 26, 2015 at 10:16 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Fri, Jul 24, 2015 at 3:04 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> From: Karthik Nayak <karthik.188@gmail.com>
>>
>> In 'tag.c' we can print N lines from the annotation of the tag using
>> the '-n<num>' option. Copy code from 'tag.c' to 'ref-filter' and
>> modify 'ref-filter' to support printing of N lines from the annotation
>> of tags.
>>
>> Mentored-by: Christian Couder <christian.couder@gmail.com>
>> Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>>  builtin/for-each-ref.c                             |   2 +-
>>  builtin/tag.c                                      |   4 +
>>  ref-filter.c                                       |  51 ++++++++-
>>  ref-filter.h                                       |   9 +-
>>  ...ter-add-option-to-align-atoms-to-the-left.patch | 124 +++++++++++++++++++++
>>  5 files changed, 186 insertions(+), 4 deletions(-)
>>  create mode 100644 v3-0001-ref-filter-add-option-to-align-atoms-to-the-left.patch
>
> Somehow you managed to "git add" and "git commit" your v3 patch 1 file
> inside this v4 patch 4/10.

Ya! removed it, thanks.

>
>> diff --git a/v3-0001-ref-filter-add-option-to-align-atoms-to-the-left.patch b/v3-0001-ref-filter-add-option-to-align-atoms-to-the-left.patch
>> new file mode 100644
>> index 0000000..350acae
>> --- /dev/null
>> +++ b/v3-0001-ref-filter-add-option-to-align-atoms-to-the-left.patch
>> @@ -0,0 +1,124 @@
>> +From 3a07ca1f56f74ca54b7f3c30e3dfd9fe2fed1cc3 Mon Sep 17 00:00:00 2001
>> +From: Karthik Nayak <karthik.188@gmail.com>
>> +Date: Wed, 10 Jun 2015 17:19:55 +0530
>> +Subject: [PATCH v3 1/9] ref-filter: add option to align atoms to the left
>> +
>> +Add a new atom "align" and support %(align:X) where X is a number.
>> +This will align the preceeding atom value to the left followed by
>> +spaces for a total length of X characters. If X is less than the item
>> +size, the entire atom value is printed.
>> +
>> +Helped-by: Duy Nguyen <pclouds@gmail.com>
>> +Mentored-by: Christian Couder <christian.couder@gmail.com>
>> +Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
>> +Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> +---
>> + ref-filter.c | 41 +++++++++++++++++++++++++++++++++++++++--
>> + ref-filter.h |  1 +
>> + 2 files changed, 40 insertions(+), 2 deletions(-)



-- 
Regards,
Karthik Nayak