* [PATCH] doc: clarify practices for submitting updated patch versions
@ 2024-04-25 21:34 Justin Tobler
2024-04-26 9:31 ` Roland Hieber
2024-04-26 10:09 ` Karthik Nayak
0 siblings, 2 replies; 3+ messages in thread
From: Justin Tobler @ 2024-04-25 21:34 UTC (permalink / raw)
To: git; +Cc: Justin Tobler
The `SubmittingPatches` documentation briefly mentions that related
patches should be grouped together in their own e-mail thread. Expand on
this to explicitly state that updated versions of a patch series should
also follow this. Also provide add a link to existing documentation from
`MyFirstContribution` that provides detailed instructions on how to do
this via `git-send-email(1)`.
Signed-off-by: Justin Tobler <jltobler@gmail.com>
---
Documentation/SubmittingPatches | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c647c7e1b4..bc212836f9 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -415,10 +415,12 @@ e-mail tools, so that they may comment on specific portions of
your code. For this reason, each patch should be submitted
"inline" in a separate message.
-Multiple related patches should be grouped into their own e-mail
-thread to help readers find all parts of the series. To that end,
-send them as replies to either an additional "cover letter" message
-(see below), the first patch, or the respective preceding patch.
+All subsequent versions of a patch series and other related patches should be
+grouped into their own e-mail thread to help readers find all parts of the
+series. To that end, send them as replies to either an additional "cover
+letter" message (see below), the first patch, or the respective preceding patch.
+Here is a link:MyFirstContribution.html#v2-git-send-email[step-by-step guide] on
+how to submit updated versions of a patch series.
If your log message (including your name on the
`Signed-off-by` trailer) is not writable in ASCII, make sure that
base-commit: e326e520101dcf43a0499c3adc2df7eca30add2d
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: clarify practices for submitting updated patch versions
2024-04-25 21:34 [PATCH] doc: clarify practices for submitting updated patch versions Justin Tobler
@ 2024-04-26 9:31 ` Roland Hieber
2024-04-26 10:09 ` Karthik Nayak
1 sibling, 0 replies; 3+ messages in thread
From: Roland Hieber @ 2024-04-26 9:31 UTC (permalink / raw)
To: Justin Tobler; +Cc: git
On Thu, Apr 25, 2024 at 04:34:04PM -0500, Justin Tobler wrote:
> The `SubmittingPatches` documentation briefly mentions that related
> patches should be grouped together in their own e-mail thread. Expand on
> this to explicitly state that updated versions of a patch series should
> also follow this. Also provide add a link to existing documentation from
> `MyFirstContribution` that provides detailed instructions on how to do
> this via `git-send-email(1)`.
Thankst! I obviously didn't read the old text in the intended way when I
submitted my patch iterations yesterday, so your patch makes it much more clear!
- Roland
> Signed-off-by: Justin Tobler <jltobler@gmail.com>
> ---
> Documentation/SubmittingPatches | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index c647c7e1b4..bc212836f9 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -415,10 +415,12 @@ e-mail tools, so that they may comment on specific portions of
> your code. For this reason, each patch should be submitted
> "inline" in a separate message.
>
> -Multiple related patches should be grouped into their own e-mail
> -thread to help readers find all parts of the series. To that end,
> -send them as replies to either an additional "cover letter" message
> -(see below), the first patch, or the respective preceding patch.
> +All subsequent versions of a patch series and other related patches should be
> +grouped into their own e-mail thread to help readers find all parts of the
> +series. To that end, send them as replies to either an additional "cover
> +letter" message (see below), the first patch, or the respective preceding patch.
> +Here is a link:MyFirstContribution.html#v2-git-send-email[step-by-step guide] on
> +how to submit updated versions of a patch series.
>
> If your log message (including your name on the
> `Signed-off-by` trailer) is not writable in ASCII, make sure that
>
> base-commit: e326e520101dcf43a0499c3adc2df7eca30add2d
> --
> 2.44.0
>
--
Roland Hieber
E-Mail: rohieb@rohieb.name
Web: https://rohieb.name
PGP Fingerprint: 3B7A C587 9464 CAB6 5B90 7151 B241 3C66 DD2C 3FEA
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: clarify practices for submitting updated patch versions
2024-04-25 21:34 [PATCH] doc: clarify practices for submitting updated patch versions Justin Tobler
2024-04-26 9:31 ` Roland Hieber
@ 2024-04-26 10:09 ` Karthik Nayak
1 sibling, 0 replies; 3+ messages in thread
From: Karthik Nayak @ 2024-04-26 10:09 UTC (permalink / raw)
To: Justin Tobler, git
[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]
Justin Tobler <jltobler@gmail.com> writes:
> The `SubmittingPatches` documentation briefly mentions that related
> patches should be grouped together in their own e-mail thread. Expand on
> this to explicitly state that updated versions of a patch series should
> also follow this. Also provide add a link to existing documentation from
> `MyFirstContribution` that provides detailed instructions on how to do
> this via `git-send-email(1)`.
>
> Signed-off-by: Justin Tobler <jltobler@gmail.com>
> ---
> Documentation/SubmittingPatches | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index c647c7e1b4..bc212836f9 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -415,10 +415,12 @@ e-mail tools, so that they may comment on specific portions of
> your code. For this reason, each patch should be submitted
> "inline" in a separate message.
>
> -Multiple related patches should be grouped into their own e-mail
> -thread to help readers find all parts of the series. To that end,
> -send them as replies to either an additional "cover letter" message
> -(see below), the first patch, or the respective preceding patch.
> +All subsequent versions of a patch series and other related patches should be
The 'other related patches' is not a strict rule we follow, is it?
> +grouped into their own e-mail thread to help readers find all parts of the
> +series. To that end, send them as replies to either an additional "cover
> +letter" message (see below), the first patch, or the respective preceding patch.
> +Here is a link:MyFirstContribution.html#v2-git-send-email[step-by-step guide] on
> +how to submit updated versions of a patch series.
Thanks for this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 690 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 21:34 [PATCH] doc: clarify practices for submitting updated patch versions Justin Tobler
2024-04-26 9:31 ` Roland Hieber
2024-04-26 10:09 ` Karthik Nayak
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).