From: "Jakub Narębski" <jnareb@gmail.com>
To: Tony Finch <dot@dotat.at>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset
Date: Sat, 3 Aug 2013 23:40:11 +0200 [thread overview]
Message-ID: <CANQwDwdA5VnywJmoNpCX7s=hH7tmUDUmRuak12W7BXOQtqRoQw@mail.gmail.com> (raw)
In-Reply-To: <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk>
On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch <dot@dotat.at> wrote:
> On the repository summary page, leave the whole owner line out if
> the repo does not have an owner, rather than displaying a labelled
> empty field..
Note that if $omit_owner is true, whole _column_ is skipped.
Is removing cell (instead of leaving it empty) and relying on browser
treating nonexistent cell correctly a good idea, that I do not know.
Does it looks better? Does it looks better in all web browsers?
> Signed-off-by: Tony Finch <dot@dotat.at>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 8d69ada..c029b98 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6463,7 +6463,7 @@ sub git_summary {
> print "<div class=\"title\"> </div>\n";
> print "<table class=\"projects_list\">\n" .
> "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n";
> - unless ($omit_owner) {
> + if ($owner and not $omit_owner) {
> print "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n";
> }
> if (defined $cd{'rfc2822'}) {
> --
> 1.8.3.1.605.g85318f5
>
--
Jakub Narebski
next prev parent reply other threads:[~2013-08-03 21:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 16:43 [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08 ` [PATCH] gitweb: vertically centre contents of page footer Tony Finch
2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder
2013-07-02 16:24 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-07-09 16:43 ` [PATCH 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08 ` [PATCH 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-07-09 17:15 ` [PATCH 4/4] gitweb: make search help link less ugly Tony Finch
2013-07-15 9:15 ` [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
[not found] ` <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk>
2013-08-03 21:37 ` [PATCH 4/4] gitweb: make search help link less ugly Jakub Narębski
2013-08-05 11:19 ` Tony Finch
[not found] ` <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk>
2013-08-03 21:40 ` Jakub Narębski [this message]
2013-08-05 11:36 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch
2013-08-20 16:59 ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-08-20 19:52 ` Junio C Hamano
2013-08-20 16:59 ` [PATCH v4 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-08-20 19:53 ` Junio C Hamano
2013-08-21 9:06 ` Tony Finch
2013-08-20 16:59 ` [PATCH v4 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-08-20 16:59 ` [PATCH v4 4/4] gitweb: make search help link less ugly Tony Finch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANQwDwdA5VnywJmoNpCX7s=hH7tmUDUmRuak12W7BXOQtqRoQw@mail.gmail.com' \
--to=jnareb@gmail.com \
--cc=dot@dotat.at \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).