git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Jakub Narębski" <jnareb@gmail.com>
To: Tony Finch <dot@dotat.at>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 4/4] gitweb: make search help link less ugly
Date: Sat, 3 Aug 2013 23:37:39 +0200	[thread overview]
Message-ID: <CANQwDwdcCUNBZH=YbSjwTZx6vau_cs89EH9FV8OUQcdNzDE5DQ@mail.gmail.com> (raw)
In-Reply-To: <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk>

On Tue, Jul 9, 2013 at 7:15 PM, Tony Finch <dot@dotat.at> wrote:

> The search help link was a superscript question mark right next to
> a drop-down menu, which looks misaligned

I think the idea was to simulate footnote explaining search terms
(I think, I am not the author of this feature)...

>                                                                and is a cramped and
> awkward click target. Remove the superscript tags and add some
> spacing to fix these nits. Add a title attribute to provide an
> explanatory mouseover.

... but I agree that it makes for poor UI.

>
> Signed-off-by: Tony Finch <dot@dotat.at>
> ---
>  gitweb/gitweb.perl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index c029b98..874c948 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4029,9 +4029,9 @@ sub print_search_form {
>               $cgi->input({-name=>"a", -value=>"search", -type=>"hidden"}) . "\n" .
>               $cgi->input({-name=>"h", -value=>$search_hash, -type=>"hidden"}) . "\n" .
>               $cgi->popup_menu(-name => 'st', -default => 'commit',
> -                              -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .
> -             $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) .
> -             " search:\n",
> +                              -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .

Nb. what changed here (in line above)?

> +             " " . $cgi->a({-href => href(action=>"search_help"),
> +                            -title => "search help" }, "?") . " search:\n",
>               $cgi->textfield(-name => "s", -value => $searchtext, -override => 1) . "\n" .
>               "<span title=\"Extended regular expression\">" .
>               $cgi->checkbox(-name => 'sr', -value => 1, -label => 're',
> --
> 1.8.3.1.605.g85318f5

  parent reply	other threads:[~2013-08-03 21:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 16:43 [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08 ` [PATCH] gitweb: vertically centre contents of page footer Tony Finch
2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder
2013-07-02 16:24   ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-07-09 16:43   ` [PATCH 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08   ` [PATCH 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-07-09 17:15   ` [PATCH 4/4] gitweb: make search help link less ugly Tony Finch
2013-07-15  9:15   ` [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
     [not found]   ` <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk>
2013-08-03 21:37     ` Jakub Narębski [this message]
2013-08-05 11:19       ` [PATCH 4/4] gitweb: make search help link less ugly Tony Finch
     [not found]   ` <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk>
2013-08-03 21:40     ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Jakub Narębski
2013-08-05 11:36       ` Tony Finch
2013-08-20 17:22         ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch
2013-08-20 16:59           ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-08-20 19:52             ` Junio C Hamano
2013-08-20 16:59           ` [PATCH v4 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-08-20 19:53             ` Junio C Hamano
2013-08-21  9:06               ` Tony Finch
2013-08-20 16:59           ` [PATCH v4 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-08-20 16:59           ` [PATCH v4 4/4] gitweb: make search help link less ugly Tony Finch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANQwDwdcCUNBZH=YbSjwTZx6vau_cs89EH9FV8OUQcdNzDE5DQ@mail.gmail.com' \
    --to=jnareb@gmail.com \
    --cc=dot@dotat.at \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).