From: Kapil Jain <jkapil.cs@gmail.com>
To: git <git@vger.kernel.org>, Thomas Gummerer <t.gummerer@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
olyatelezhnaya@gmail.com
Subject: [GSoC] Unify ref-filter formats with other --pretty formats
Date: Tue, 26 Mar 2019 00:56:50 +0530 [thread overview]
Message-ID: <CAMknYEPrrpxESK0onwTHRbVwcZE2YQpT=RVzjb9JfEBEXt4NRA@mail.gmail.com> (raw)
Hi,
Below are some two queries concerning
https://git.github.io/SoC-2019-Ideas/#unify-ref-filter-formats-with-other---pretty-formats
Q1)
In pretty.h & pretty.c:
void get_commit_format(const char *arg, struct rev_info *);
This function Parses given arguments from "arg", checks it for
correctness and * fill struct rev_info.
In ref-filter.h & ref-filter.c:
int verify_ref_format(struct ref_format *format);
This function is Used to verify if the given format is correct and to
parse out the used atoms.
Now, the verify_ref_format function can be used inside
get_commit_format function, hence reusing logic.
Is this a correct example to work on, for this project ?
If not, please point out an example so as to understand the problem
statement better.
Other than this I can't find any other example, for this project in
pretty.* and ref-filter.*
Perhaps some examples could be found in command specific files, right ?
Q2)
About a recurring term 'atom' in ref-filter and pretty:
what is atom ? is it a piece of a whole document ? and what is meant
by used atoms ?
Thanks.
next reply other threads:[~2019-03-25 19:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 19:26 Kapil Jain [this message]
2019-03-25 21:17 ` [GSoC] Unify ref-filter formats with other --pretty formats Olga Telezhnaya
2019-03-27 17:01 ` Kapil Jain
2019-03-28 17:43 ` Olga Telezhnaya
2019-03-29 13:53 ` Kapil Jain
2019-03-31 17:45 ` Kapil Jain
2019-03-31 18:49 ` Thomas Gummerer
2019-04-01 12:58 ` Kapil Jain
2019-03-31 19:28 ` Olga Telezhnaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMknYEPrrpxESK0onwTHRbVwcZE2YQpT=RVzjb9JfEBEXt4NRA@mail.gmail.com' \
--to=jkapil.cs@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=olyatelezhnaya@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).