From: Kapil Jain <jkapil.cs@gmail.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: Olga Telezhnaya <olyatelezhnaya@gmail.com>,
git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [GSoC] Unify ref-filter formats with other --pretty formats
Date: Mon, 1 Apr 2019 18:28:46 +0530 [thread overview]
Message-ID: <CAMknYENiA8sEm0vPk1nn45i_VomjeFpjy0bxPLixEa_Mg1eazw@mail.gmail.com> (raw)
In-Reply-To: <20190331184930.GV32487@hank.intra.tgummerer.com>
On Mon, Apr 1, 2019 at 12:19 AM Thomas Gummerer <t.gummerer@gmail.com> wrote:
>
> If you look at what userformat_find_requirements() does, calls
> strbuf_expand(), which in turn calls userformat_want_item(), which
> fills the 'userformat_want' struct based on the strbuf that has been
> passed.
>
> Now if we look at the caller of userformat_find_requirements(), which
> is cmd_log_init_finish(), you can see where 'w.notes' and 'w.source'
> is used.
>
i actually got to userformat_find_requirements() by tracing from
cmd_log() itself. although i won't say i read the
cmd_log_init_finish() line by line.
will do.
next prev parent reply other threads:[~2019-04-01 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 19:26 [GSoC] Unify ref-filter formats with other --pretty formats Kapil Jain
2019-03-25 21:17 ` Olga Telezhnaya
2019-03-27 17:01 ` Kapil Jain
2019-03-28 17:43 ` Olga Telezhnaya
2019-03-29 13:53 ` Kapil Jain
2019-03-31 17:45 ` Kapil Jain
2019-03-31 18:49 ` Thomas Gummerer
2019-04-01 12:58 ` Kapil Jain [this message]
2019-03-31 19:28 ` Olga Telezhnaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMknYENiA8sEm0vPk1nn45i_VomjeFpjy0bxPLixEa_Mg1eazw@mail.gmail.com \
--to=jkapil.cs@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=olyatelezhnaya@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).