From: Xidorn Quan <quanxunzhen@gmail.com>
To: John Szakmeister <john@szakmeister.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] credential-osxkeychain: support more protocols
Date: Mon, 27 May 2013 21:57:01 +0800 [thread overview]
Message-ID: <CAMdq69_=21de4FvGkp0bFtZjNOttkwXOxjvhM0yZi5gyj0-V9g@mail.gmail.com> (raw)
In-Reply-To: <CAEBDL5W4sLB0R1ZOspb-yQzmyTCE7Y1HeC2KZ69F8R28fJY7_A@mail.gmail.com>
On Mon, May 27, 2013 at 6:27 PM, John Szakmeister <john@szakmeister.net> wrote:
>
> On Mon, May 27, 2013 at 3:57 AM, Xidorn Quan <quanxunzhen@gmail.com> wrote:
> > Add protocol ftp, smtp, and ssh for credential-osxkeychain.
> > ---
> > contrib/credential/osxkeychain/git-credential-osxkeychain.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> > index 3940202..4ddcfb3 100644
> > --- a/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> > +++ b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> > @@ -127,10 +127,16 @@ static void read_credential(void)
> > *v++ = '\0';
> >
> > if (!strcmp(buf, "protocol")) {
> > - if (!strcmp(v, "https"))
> > + if (!strcmp(v, "ftp"))
> > + protocol = kSecProtocolTypeFTP;
> > + else if (!strcmp(v, "https"))
> > protocol = kSecProtocolTypeHTTPS;
> > else if (!strcmp(v, "http"))
> > protocol = kSecProtocolTypeHTTP;
> > + else if (!strcmp(v, "smtp"))
> > + protocol = kSecProtocolTypeSMTP;
> > + else if (!strcmp(v, "ssh"))
> > + protocol = kSecProtocolTypeSSH;
> > else /* we don't yet handle other protocols */
> > exit(0);
>
> This looks pretty good, except the last one raises a question. I'm
> using Mac OS X, and ssh already interacts with keychain to get my SSH
> key password. Is this mainly for password logins via SSH? Assuming
> that's the case:
>
> Signed-off-by: John Szakmeister <john@szakmeister.net>
>
> -John
I thought that SSH password logins can benefit from it, but I just
found that it is wrong because it seems that SSH client is responsible
for authenticating. Consequently, supporting SSH here is useless.
I will remove that lines and send this patch again.
Since it is the first time I submit a patch to git, I am not very
familiar with the convention here. Should I send the modified patch
to the maintainer directly? And what information should I append to
my patch before it can get merged?
--
Xidorn Quan
next prev parent reply other threads:[~2013-05-27 13:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 7:57 [PATCH] credential-osxkeychain: support more protocols Xidorn Quan
2013-05-27 10:27 ` John Szakmeister
2013-05-27 13:57 ` Xidorn Quan [this message]
[not found] ` <CAMdq6987TAj7f03mABkqu9v4wicarrZLYQypNUiOrP0fsLc4mQ@mail.gmail.com>
2013-05-27 14:28 ` John Szakmeister
2013-05-27 15:02 ` Xidorn Quan
2013-05-27 14:35 ` [PATCH v2] " Xidorn Quan
2013-05-27 15:08 ` Jeff King
2013-05-27 15:46 ` Xidorn Quan
2013-05-27 16:05 ` Jeff King
2013-05-28 2:36 ` [PATCH v3] " Xidorn Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMdq69_=21de4FvGkp0bFtZjNOttkwXOxjvhM0yZi5gyj0-V9g@mail.gmail.com' \
--to=quanxunzhen@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@szakmeister.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).