From: Xidorn Quan <quanxunzhen@gmail.com>
To: git@vger.kernel.org
Cc: Xidorn Quan <quanxunzhen@gmail.com>,
John Szakmeister <john@szakmeister.net>,
Jeff King <peff@peff.net>
Subject: [PATCH v2] credential-osxkeychain: support more protocols
Date: Mon, 27 May 2013 22:35:59 +0800 [thread overview]
Message-ID: <1369665359-48242-1-git-send-email-quanxunzhen@gmail.com> (raw)
In-Reply-To: <1369641431-44504-1-git-send-email-quanxunzhen@gmail.com>
Add protocol ftp and smtp for credential-osxkeychain.
Acked-by: John Szakmeister <john@szakmeister.net>
Signed-off-by: Xidorn Quan <quanxunzhen@gmail.com>
---
contrib/credential/osxkeychain/git-credential-osxkeychain.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
index 3940202..648fadd 100644
--- a/contrib/credential/osxkeychain/git-credential-osxkeychain.c
+++ b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
@@ -127,10 +127,14 @@ static void read_credential(void)
*v++ = '\0';
if (!strcmp(buf, "protocol")) {
- if (!strcmp(v, "https"))
+ if (!strcmp(v, "ftp"))
+ protocol = kSecProtocolTypeFTP;
+ else if (!strcmp(v, "https"))
protocol = kSecProtocolTypeHTTPS;
else if (!strcmp(v, "http"))
protocol = kSecProtocolTypeHTTP;
+ else if (!strcmp(v, "smtp"))
+ protocol = kSecProtocolTypeSMTP;
else /* we don't yet handle other protocols */
exit(0);
}
--
1.8.3
next prev parent reply other threads:[~2013-05-27 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 7:57 [PATCH] credential-osxkeychain: support more protocols Xidorn Quan
2013-05-27 10:27 ` John Szakmeister
2013-05-27 13:57 ` Xidorn Quan
[not found] ` <CAMdq6987TAj7f03mABkqu9v4wicarrZLYQypNUiOrP0fsLc4mQ@mail.gmail.com>
2013-05-27 14:28 ` John Szakmeister
2013-05-27 15:02 ` Xidorn Quan
2013-05-27 14:35 ` Xidorn Quan [this message]
2013-05-27 15:08 ` [PATCH v2] " Jeff King
2013-05-27 15:46 ` Xidorn Quan
2013-05-27 16:05 ` Jeff King
2013-05-28 2:36 ` [PATCH v3] " Xidorn Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369665359-48242-1-git-send-email-quanxunzhen@gmail.com \
--to=quanxunzhen@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@szakmeister.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).