Re: [PATCH 1/3] cherry-pick: add support to copy notes

[Felipe Contreras <felipe.contreras@gmail.com>]

On Wed, May 29, 2013 at 7:09 AM, Ramkumar Ramachandra
<artagnon@gmail.com> wrote:
> Thomas Rast wrote:
>> So until this changes, my $0.02 is a blanket NAK and a refusal to spend
>> my time reviewing.
>
> Then don't review the damn thing.  With Felipe, I have the following
> rule of thumb: make some concrete suggestions and forget about
> follow-ups.

He didn't make any suggestions.

> He's not going to accept any general guidelines, unless
> you're quoting Documentation/SubmittingPatches (and even then, it's
> subject to interpretation); so provide a commit message and hope that
> either he or Junio will use it.  There is no guarantee that he will
> take any of your suggestions, no matter how sensible you think they
> might be.

This is bullshit.

Let's look at some of the suggestions you have made:

== git-related ==

> s/l/line/?

I said fine, and I implemented it.

> Still no -CCC?

I said I forgot, and I implemented it.

What you are really complaining about is that I don't agree with
*every* single suggestion you make. And since you made them, they must
be sensible, and single I don't agree with you, I must not be
sensible, is that right?

And stop bringing irrelevant garbage to this discussion. The
discussion about the coding-style not about guidelines, because there
is no guideline for that open parenthesis, ad obviated by the fact
that there's over *FIVE HUNDRED* instances where it's not aligned that
way.

Nobody is denying the notes.rewritten.* guideline here, I didn't
because that is *actually* a guideline. So your comment about
guidelines is an irrelevant straw man.

> However, he is a productive programmer, and submits fixes
> to real issues.  He's stubborn, and we can't do much to change that:
> just learn to work with him.  I'm disappointed that I have to point
> this out: haven't you learnt anything from previous discussions with
> him?
>
> Felipe, I suggest you put this in your commit message:
>
>    This patch implements --copy-notes for 'git cherry-pick' so it can
> copy notes in the same way that 'git rebase' does.
>
> That is, if it's not too much trouble.
>
> Stop this back-and-fourth nonsense, both of you.  It's degrading the
> community, and hitting everyone's inboxes with garbage.

Thanks.

But let's take a step backwards, what are we trying to achieve here?
We are trying to improve Git, and the indisputable fact is that 'git
cherry-pick' is missing a way to copy the notes.

It's indisputable that this patch implements that, and I did it by
following existing code, and by running the whole test suit for 'git
rebase'. I've done my job already.

Thomas Rast doesn't like the way this is implemented, and nothing in
the commit message would change that.

This is was a sensible community, you would stop ganging up on me,
Thomas Rast would implement copy_notes_for_rewrite(), and add tests
for other commits (git am, git rebase) to check that the functionality
he claims to be so worried about is working properly.

And this was a sensible community you wouldn't complain about me
choosing how to spend my time however I see fit.

I did some work, I sent a patch, Thomas Rast has some issues, I'm not
interested enough in this patch to investigate them, I work on
something else. What's wrong with that?

Eventually I might come back to this patch, and eventually I might
implement copy_notes_for_rewrite, and I might implement the tests that
check for the behavior that I missed, if nobody beats me to it, which
is usually the case, but I think Thomas should put his personal issues
aside, put his money where his mouth is, and implement it himself.

There's nothing wrong with me choosing how best to spend my time. Really.

-- 
Felipe Contreras