git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Thomas Rast <trast@inf.ethz.ch>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/3] cherry-pick: add support to copy notes
Date: Wed, 29 May 2013 19:18:48 +0530	[thread overview]
Message-ID: <CALkWK0kK+Mbscsue0wwU5QDKXCrw5Q078MCdOVCoJnMZq7T6UA@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s2tvUs813hrheWpWXR2G4kMJL4rscEtynaKYvw5a6HCHA@mail.gmail.com>

Felipe Contreras wrote:
> What you are really complaining about is that I don't agree with
> *every* single suggestion you make. And since you made them, they must
> be sensible, and single I don't agree with you, I must not be
> sensible, is that right?

Oh, I have no problems: I reviewed git-related, and it resulted in
massive simplifications and improvements; those threads didn't run
wild.  I was mainly criticizing Thomas' review style (when it comes to
reviewing your patches in particular), and was prodding him to "make
concrete suggestions" in a one-email review, and leave it at that.
What started out as a pointer to the guidelines:

Thomas Rast wrote:
> We've been over this already:
>
>   The body should provide a meaningful commit message, which:

has resulted in this thread running wild.

> There's nothing wrong with me choosing how best to spend my time. Really.

Ofcourse you are.  You have arguably spent it very productively
solving a lot of user issues (especially remote-bzr).

Personally, I try to do the minimum amount of boring work required to
make sure that a good series gets in.  Sometimes this is a little high
(for a recent example, see my pickaxe-doc series).  The result being
that I just won't work on documentation in the future because doing
iterations is so piss boring: the git community needs to recognize
this problem and make amends.

  reply	other threads:[~2013-05-29 13:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 12:59 [PATCH 0/3] cherry-pick: improvments Felipe Contreras
2013-05-28 12:59 ` [PATCH 1/3] cherry-pick: add support to copy notes Felipe Contreras
2013-05-28 17:07   ` Junio C Hamano
2013-05-28 18:01     ` Thomas Rast
2013-05-29  2:46       ` Felipe Contreras
2013-05-29  8:09         ` Thomas Rast
2013-05-29  8:19           ` Felipe Contreras
2013-05-29  8:40             ` Thomas Rast
2013-05-29 11:18               ` Felipe Contreras
2013-05-29 11:34                 ` Thomas Rast
2013-05-29 11:56                   ` Felipe Contreras
2013-05-29 12:09               ` Ramkumar Ramachandra
2013-05-29 13:18                 ` Felipe Contreras
2013-05-29 13:48                   ` Ramkumar Ramachandra [this message]
2013-05-29 14:01                     ` Felipe Contreras
2013-05-29  2:41     ` Felipe Contreras
2013-05-28 12:59 ` [PATCH 2/3] revert/cherry-pick: add --quiet option Felipe Contreras
2013-05-28 12:59 ` [PATCH 3/3] revert/cherry-pick: add --skip option Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALkWK0kK+Mbscsue0wwU5QDKXCrw5Q078MCdOVCoJnMZq7T6UA@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=trast@inf.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).