From: Felipe Contreras <felipe.contreras@gmail.com>
To: Ted Pavlic <ted@tedpavlic.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Thomas Rast" <trast@student.ethz.ch>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Kerrick Staley" <mail@kerrickstaley.com>,
"Marius Storm-Olsen" <mstormo@gmail.com>,
"Ville Skyttä" <ville.skytta@iki.fi>,
"Dan McGee" <dan@archlinux.org>
Subject: Re: [PATCH 2/2] completion: split __git_ps1 into a separate script
Date: Wed, 23 May 2012 13:53:07 +0200 [thread overview]
Message-ID: <CAMP44s0jLdNo89+c7+fBSokdxhCvPRnRKfhgVKnziMmv0vySXw@mail.gmail.com> (raw)
In-Reply-To: <CAOnadRGgduprp_Dbjzf_TsyQQQjivzKxCgUq4y_HevvtKd7h7Q@mail.gmail.com>
On Wed, May 23, 2012 at 12:27 AM, Ted Pavlic <ted@tedpavlic.com> wrote:
>> The solution, proposed by Kerrick Staley[3], is to split the git script
>> in two; the part that deals with __git_ps1() in one (i.e.
>> git-prompt.sh), and everything else in another (i.e.
>> git-completion.bash).
>
> Seems like this solution has popped up on lots of forums for about
> every Linux distribution around the time the new bash completion was
> introduced. I'm not sure Kerric Staley deserves sole attribution
> (sorry Kerrick; I mean no offense).
I didn't attribute it to him, I merely said he proposed it, which he
did, I did not make any statement about him being the sole author of
this idea.
I don't recall this solution for this problem being proposed in this
mailing list by anybody else though. And I don't think it's relevant.
> Moreover, every time the subject of splitting __gitdir out comes up, a
> side discussion about all of the complications that could cause comes
> up... and people give up and hope that the folks upstream (i.e., here)
> will come up with a better solution.
This is the reply Kerrick got to his suggestion from Jeff King:
http://article.gmane.org/gmane.comp.version-control.git/194230
I also agreed, and so did Jonathan Nieder:
http://article.gmane.org/gmane.comp.version-control.git/194950
So I don't see what you mean by those side "discussions" I recall
Junio objecting to this, but the split was meant to solve another
issue (zsh).
> If it was so simple to just split __gitdir out, I think it would have
> already been done.
>
>> The only slight issue is that __gitdir() would be duplicated, but this
>> is probably not a big deal.
>
> That seems ugly. I know that splitting __gitdir out is also ugly, but
> I know that there are going to be a lot more people who use git
> completion than git_ps1. Consequently, in a duplicated __gitdir
> scneario, I worry that __gitdir will receive more attention and may
> relatively quickly diverge in implementation if not very careful in
> approving patches. Moreover, a __gitdir of the future may not be
> atomic and will pick up side effects and become impossible to manage
> in two places.
Perhaps, but it wouldn't work worst than the current __gitdir(). And I
haven't heard any better suggestions yet.
> So maybe a split out "git-gitdir.sh" that both files include would be
> "better." Either that or the functionality of "__gitdir" gets pulled
> into git itself. (perhaps a git-gitdir added to the main git
> distribution)
I like the idea of 'git gitdir' (or 'git dir'), and I dislike the idea
of 'git-gitdir.sh'; people would need to copy one extra file, and
probably edit multiple files.
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> As the patch is from you, there's no need to sign off on it too.
Yes I do, according to Linux guidelines[1], and that's what I've been
always doing in the git mailing list.
Anyway, before going straight to a negative attitude, why don't we
wait for more comments before making any conclusions?
Cheers.
[1] http://www.kernel.org/doc/Documentation/SubmittingPatches
--
Felipe Contreras
next prev parent reply other threads:[~2012-05-23 11:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 20:46 [PATCH 0/2] completion: split into git-prompt.sh Felipe Contreras
2012-05-22 20:46 ` [PATCH 1/2] completion: remove executable mode Felipe Contreras
2012-05-22 20:46 ` [PATCH 2/2] completion: split __git_ps1 into a separate script Felipe Contreras
2012-05-22 21:07 ` Zbigniew Jędrzejewski-Szmek
2012-05-22 22:29 ` Ted Pavlic
2012-05-23 11:56 ` Felipe Contreras
2012-05-23 11:59 ` Felipe Contreras
2012-05-23 14:54 ` Junio C Hamano
2012-05-23 15:40 ` Felipe Contreras
2012-05-23 16:30 ` Junio C Hamano
2012-05-23 17:03 ` Ted Pavlic
2012-05-23 20:50 ` Felipe Contreras
2012-05-23 21:55 ` Ted Pavlic
2012-05-24 20:35 ` SZEDER Gábor
[not found] ` <CAOnadRFbrhrFz7Ya3Vhgsju9G723Qu0OdJnM31xFmBqQNgj6gA@mail.gmail.com>
2012-05-25 7:35 ` SZEDER Gábor
2012-05-25 7:50 ` Thomas Rast
2012-05-25 10:01 ` Felipe Contreras
2012-05-25 18:03 ` Junio C Hamano
2012-05-24 20:49 ` SZEDER Gábor
2012-05-22 22:27 ` Ted Pavlic
2012-05-23 11:53 ` Felipe Contreras [this message]
2012-05-23 14:59 ` Junio C Hamano
2012-05-24 20:47 ` SZEDER Gábor
2012-05-25 17:51 ` Ville Skyttä
2012-10-25 0:51 ` Where should git-prompt.sh be installed? Jonathan Nieder
2012-10-25 1:59 ` Drew Northup
2012-10-25 6:02 ` Danny Yates
2012-10-25 7:45 ` [RFC/PATCH] __git_ps1: migrate out of contrib/completion Jonathan Nieder
2012-10-25 14:19 ` Felipe Contreras
2012-11-08 13:19 ` Todd Zullinger
2012-10-25 8:10 ` Where should git-prompt.sh be installed? Anders Kaseorg
2012-10-25 15:11 ` SZEDER Gábor
2012-10-25 16:12 ` Jonathan Nieder
2012-05-23 16:33 ` [PATCH 0/2] completion: split into git-prompt.sh Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s0jLdNo89+c7+fBSokdxhCvPRnRKfhgVKnziMmv0vySXw@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=dan@archlinux.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@kerrickstaley.com \
--cc=mstormo@gmail.com \
--cc=szeder@ira.uka.de \
--cc=ted@tedpavlic.com \
--cc=trast@student.ethz.ch \
--cc=ville.skytta@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).