From: Felipe Contreras <felipe.contreras@gmail.com>
To: Ted Pavlic <ted@tedpavlic.com>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Thomas Rast" <trast@student.ethz.ch>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Kerrick Staley" <mail@kerrickstaley.com>,
"Marius Storm-Olsen" <mstormo@gmail.com>,
"Ville Skyttä" <ville.skytta@iki.fi>,
"Dan McGee" <dan@archlinux.org>
Subject: Re: [PATCH 2/2] completion: split __git_ps1 into a separate script
Date: Wed, 23 May 2012 13:56:11 +0200 [thread overview]
Message-ID: <CAMP44s0X3G_eL6R4i+arLEPS3B5DzeXoFEqax_GDi-TQ+LVzFQ@mail.gmail.com> (raw)
In-Reply-To: <CAOnadRGBi0+Zno_eqzzkJjoUfXh=vEpEV5Cf_6zjOV42XPjXdg@mail.gmail.com>
On Wed, May 23, 2012 at 12:29 AM, Ted Pavlic <ted@tedpavlic.com> wrote:
>>> create mode 100644 contrib/completion/git-prompt.sh
>> Hi,
>> since git-prompt is not completion related anymore, should a different
>> directory be used?
>
> Making it even more likely that the __gitdir in one will someday not
> match the __gitdir in another...
Which is not a big deal IMO. The "bad" __gitdir() won't get worst than
the current one.
> Maybe __gitdir should live inside git-prompt and git-completion would
> include git-prompt. That would make everything backward compatible
> too. And that way there's a good answer to why git-prompt lives inside
> the completion directory.
That's not bad, but still needs people to copy multiple scripts, and
edit. I prefer to have a 'git dir' or something.
--
Felipe Contreras
next prev parent reply other threads:[~2012-05-23 11:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 20:46 [PATCH 0/2] completion: split into git-prompt.sh Felipe Contreras
2012-05-22 20:46 ` [PATCH 1/2] completion: remove executable mode Felipe Contreras
2012-05-22 20:46 ` [PATCH 2/2] completion: split __git_ps1 into a separate script Felipe Contreras
2012-05-22 21:07 ` Zbigniew Jędrzejewski-Szmek
2012-05-22 22:29 ` Ted Pavlic
2012-05-23 11:56 ` Felipe Contreras [this message]
2012-05-23 11:59 ` Felipe Contreras
2012-05-23 14:54 ` Junio C Hamano
2012-05-23 15:40 ` Felipe Contreras
2012-05-23 16:30 ` Junio C Hamano
2012-05-23 17:03 ` Ted Pavlic
2012-05-23 20:50 ` Felipe Contreras
2012-05-23 21:55 ` Ted Pavlic
2012-05-24 20:35 ` SZEDER Gábor
[not found] ` <CAOnadRFbrhrFz7Ya3Vhgsju9G723Qu0OdJnM31xFmBqQNgj6gA@mail.gmail.com>
2012-05-25 7:35 ` SZEDER Gábor
2012-05-25 7:50 ` Thomas Rast
2012-05-25 10:01 ` Felipe Contreras
2012-05-25 18:03 ` Junio C Hamano
2012-05-24 20:49 ` SZEDER Gábor
2012-05-22 22:27 ` Ted Pavlic
2012-05-23 11:53 ` Felipe Contreras
2012-05-23 14:59 ` Junio C Hamano
2012-05-24 20:47 ` SZEDER Gábor
2012-05-25 17:51 ` Ville Skyttä
2012-10-25 0:51 ` Where should git-prompt.sh be installed? Jonathan Nieder
2012-10-25 1:59 ` Drew Northup
2012-10-25 6:02 ` Danny Yates
2012-10-25 7:45 ` [RFC/PATCH] __git_ps1: migrate out of contrib/completion Jonathan Nieder
2012-10-25 14:19 ` Felipe Contreras
2012-11-08 13:19 ` Todd Zullinger
2012-10-25 8:10 ` Where should git-prompt.sh be installed? Anders Kaseorg
2012-10-25 15:11 ` SZEDER Gábor
2012-10-25 16:12 ` Jonathan Nieder
2012-05-23 16:33 ` [PATCH 0/2] completion: split into git-prompt.sh Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s0X3G_eL6R4i+arLEPS3B5DzeXoFEqax_GDi-TQ+LVzFQ@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=dan@archlinux.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@kerrickstaley.com \
--cc=mstormo@gmail.com \
--cc=szeder@ira.uka.de \
--cc=ted@tedpavlic.com \
--cc=trast@student.ethz.ch \
--cc=ville.skytta@iki.fi \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).