From: Felipe Contreras <felipe.contreras@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Stephen Boyd <bebarino@gmail.com>,
Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH 2/3] test: improve rebase -q test
Date: Sat, 8 Jun 2013 05:15:52 -0500 [thread overview]
Message-ID: <CAMP44s012kdYH5tRBnH4ijsGuVVDUe1Zbo4XkFx+wQNwOt_trg@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8DHeqOz=WbxurCvPiDq73k4eftwrEEZzWBbifS51PDbLQ@mail.gmail.com>
On Fri, Jun 7, 2013 at 9:44 PM, Duy Nguyen <pclouds@gmail.com> wrote:
> On Sat, Jun 8, 2013 at 3:32 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> Let's show the output so it's clear why it failed.
>
> I think you can always look into trash-directory.t3400 and figure why.
> But if you show this, I think you should use test_cmp to make it clear
> what is not wanted. Something like
>
> : >expected &&
> test_cmp expected output.out
Feel free to send that patch. I'm done with this one.
--
Felipe Contreras
next prev parent reply other threads:[~2013-06-08 10:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 20:32 [PATCH 0/3] Trivial patches Felipe Contreras
2013-06-07 20:32 ` [PATCH 1/3] sequencer: trivial fix Felipe Contreras
2013-06-07 22:49 ` Junio C Hamano
2013-06-07 22:59 ` Felipe Contreras
2013-06-07 20:32 ` [PATCH 2/3] test: improve rebase -q test Felipe Contreras
2013-06-08 2:44 ` Duy Nguyen
2013-06-08 10:15 ` Felipe Contreras [this message]
2013-06-09 18:30 ` Junio C Hamano
2013-06-09 18:35 ` Felipe Contreras
2013-06-09 19:20 ` Junio C Hamano
2013-06-09 19:33 ` Felipe Contreras
2013-06-09 20:35 ` Junio C Hamano
2013-06-09 20:41 ` Felipe Contreras
2013-06-10 9:39 ` SZEDER Gábor
2013-06-10 15:56 ` Junio C Hamano
2013-06-10 17:01 ` Felipe Contreras
2013-06-10 17:27 ` SZEDER Gábor
2013-06-10 19:07 ` Johannes Sixt
2013-06-10 20:19 ` SZEDER Gábor
2013-06-10 19:17 ` Junio C Hamano
2013-06-09 22:44 ` Philip Oakley
2013-06-09 23:39 ` Junio C Hamano
2013-06-10 20:41 ` Jeff King
2013-06-07 20:32 ` [PATCH 3/3] submodule: remove unnecessary check Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s012kdYH5tRBnH4ijsGuVVDUe1Zbo4XkFx+wQNwOt_trg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=artagnon@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).