From: Johannes Sixt <j6t@kdbg.org>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Stephen Boyd <bebarino@gmail.com>,
Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH 2/3] test: improve rebase -q test
Date: Mon, 10 Jun 2013 21:07:06 +0200 [thread overview]
Message-ID: <51B623DA.4050802@kdbg.org> (raw)
In-Reply-To: <20130610172708.GH2091@goldbirke>
Am 10.06.2013 19:27, schrieb SZEDER Gábor:
> My main motivation is that, like in your example, in the bash prompt
> tests I only have to check a single line of output, but because of
> debuggability I always did:
>
> echo "(master)" >expected
> __git_ps1 >actual
> test_cmp expected actual
Chained by &&, I presume.
> With such a helper function this could be reduced to a single line:
>
> test_string_equal "(master)" "$(__git_ps1)"
>
> without loss of functionality
Not quite: A non-zero exit code of the $(__git_ps1) is lost. (It
probably doesn't matter here, but it certainly does if the command is
$(git rev-parse foo) or similar.)
-- Hannes
next prev parent reply other threads:[~2013-06-10 19:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 20:32 [PATCH 0/3] Trivial patches Felipe Contreras
2013-06-07 20:32 ` [PATCH 1/3] sequencer: trivial fix Felipe Contreras
2013-06-07 22:49 ` Junio C Hamano
2013-06-07 22:59 ` Felipe Contreras
2013-06-07 20:32 ` [PATCH 2/3] test: improve rebase -q test Felipe Contreras
2013-06-08 2:44 ` Duy Nguyen
2013-06-08 10:15 ` Felipe Contreras
2013-06-09 18:30 ` Junio C Hamano
2013-06-09 18:35 ` Felipe Contreras
2013-06-09 19:20 ` Junio C Hamano
2013-06-09 19:33 ` Felipe Contreras
2013-06-09 20:35 ` Junio C Hamano
2013-06-09 20:41 ` Felipe Contreras
2013-06-10 9:39 ` SZEDER Gábor
2013-06-10 15:56 ` Junio C Hamano
2013-06-10 17:01 ` Felipe Contreras
2013-06-10 17:27 ` SZEDER Gábor
2013-06-10 19:07 ` Johannes Sixt [this message]
2013-06-10 20:19 ` SZEDER Gábor
2013-06-10 19:17 ` Junio C Hamano
2013-06-09 22:44 ` Philip Oakley
2013-06-09 23:39 ` Junio C Hamano
2013-06-10 20:41 ` Jeff King
2013-06-07 20:32 ` [PATCH 3/3] submodule: remove unnecessary check Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B623DA.4050802@kdbg.org \
--to=j6t@kdbg.org \
--cc=Jens.Lehmann@web.de \
--cc=artagnon@gmail.com \
--cc=bebarino@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).