From: Alex Henrie <alexhenrie24@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] gc: don't translate literal commands
Date: Tue, 20 Sep 2022 13:43:56 -0600 [thread overview]
Message-ID: <CAMMLpeRCHbp0OgsXOoMhJcUjS=sUCDJmcA=S1_dbd6Vk31C3+w@mail.gmail.com> (raw)
In-Reply-To: <YyoPXmNGAvl6p+C2@coredump.intra.peff.net>
On Tue, Sep 20, 2022 at 1:07 PM Jeff King <peff@peff.net> wrote:
>
> On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:
>
> > These commands have no placeholders to be translated.
>
> I think this is the right thing to do, but your commit message made me
> pause for a second. When you say "placeholders", I think you mean %s,
> etc. And yes there aren't any here, but that is not the reason not to
> translate. The reason not to translate is that the strings are commands
> which are given to a machine.
>
> So maybe something like:
>
> There are no human-readable parts of these strings; the command you
> type is still "git maintenance" even in other languages.
By "placeholders" I mean "things in angle brackets", like some of the
other usage strings in this file have. Maybe "argument placeholders"
would be more clear. I like that term a little better than the term
"human-readable parts" because these strings are part of the user
interface, so humans have to read them. But I really don't care
whether there's any explanation in the commit message at all. Junio
could just drop the sentence altogether when he commits the patch.
> Regardless, the patch looks good to me. Thanks for catching it.
No problem, and thanks for the feedback.
-Alex
next prev parent reply other threads:[~2022-09-20 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 5:07 [PATCH] gc: don't translate literal commands Alex Henrie
2022-09-20 19:07 ` Jeff King
2022-09-20 19:43 ` Alex Henrie [this message]
2022-09-20 19:55 ` Jeff King
2022-09-21 17:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMMLpeRCHbp0OgsXOoMhJcUjS=sUCDJmcA=S1_dbd6Vk31C3+w@mail.gmail.com' \
--to=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).