mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Jeff King <>
Cc: Alex Henrie <>,
Subject: Re: [PATCH] gc: don't translate literal commands
Date: Wed, 21 Sep 2022 10:35:14 -0700	[thread overview]
Message-ID: <xmqqa66s4oml.fsf@gitster.g> (raw)
In-Reply-To: <> (Jeff King's message of "Tue, 20 Sep 2022 15:07:10 -0400")

Jeff King <> writes:

> On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:
>> These commands have no placeholders to be translated.
> I think this is the right thing to do, but your commit message made me
> pause for a second. When you say "placeholders", I think you mean %s,
> etc. And yes there aren't any here, but that is not the reason not to
> translate. The reason not to translate is that the strings are commands
> which are given to a machine.

I had the same reaction.  The strings shown in the choices need to
be given as spelled and there is no i18n there.

> So maybe something like:
>   There are no human-readable parts of these strings; the command you
>   type is still "git maintenance" even in other languages.

I think calling that "no human-readable" would probably give another
confusion, though.

The title uses a good phrase: "literal commands", so the latter half
of your rewrite should be sufficient.

    The command you type is still "git maintenance" even in other

> Regardless, the patch looks good to me. Thanks for catching it.

Yes.  Good finding.

Will apply.

      parent reply	other threads:[~2022-09-21 17:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  5:07 [PATCH] gc: don't translate literal commands Alex Henrie
2022-09-20 19:07 ` Jeff King
2022-09-20 19:43   ` Alex Henrie
2022-09-20 19:55     ` Jeff King
2022-09-21 17:35   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa66s4oml.fsf@gitster.g \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).