From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Martin Langhoff" <martin@laptop.org>,
"Martin Langhoff" <martin.langhoff@gmail.com>,
"Paul Mackerras" <paulus@samba.org>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] gitk: add support for -G'regex' pickaxe variant
Date: Tue, 14 May 2013 02:34:20 +0530 [thread overview]
Message-ID: <CALkWK0kVa-9-G8-2HtH1_cd1LY65abU8R4WKcjgkyTSh=xQamw@mail.gmail.com> (raw)
In-Reply-To: <20130513193320.GC3657@google.com>
Jonathan Nieder wrote:
> Martin Langhoff wrote:
>> On Mon, May 13, 2013 at 2:55 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
>>> My experience is the opposite. I wonder "What did the author of this
>>> nonsense comment mean?" or "What is the purpose of this strange
>>> condition in this if () statement?". Then "git log -S" finds the
>>> culprit
>>
>> Only if that if () statement looks that way from a single commit.
>> That's my point. If the line code bit you are looking at is the result
>> of several changes, your log -S will grind a while and find you
>> nothing.
>
> Well, no, it should find the final change that brought it into the
> current form. Just like "git blame".
I still don't know exactly what -G and -S do. The documentation can
be improved, no? A nice example would definitely help.
Thanks.
next prev parent reply other threads:[~2013-05-13 21:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 2:32 [PATCH] gitk: add support for -G'regex' pickaxe variant Martin Langhoff
2012-06-09 9:16 ` Zbigniew Jędrzejewski-Szmek
2012-06-10 6:37 ` Junio C Hamano
2012-06-10 7:24 ` Paul Mackerras
2012-06-10 7:31 ` Junio C Hamano
2012-06-14 18:34 ` Zbigniew Jędrzejewski-Szmek
2013-05-07 17:17 ` Martin Langhoff
2013-05-07 20:30 ` Felipe Contreras
2013-05-11 5:56 ` Paul Mackerras
2013-05-11 6:13 ` Jonathan Nieder
2013-05-11 9:41 ` Paul Mackerras
2013-05-13 16:22 ` Martin Langhoff
2013-05-13 18:55 ` Jonathan Nieder
2013-05-13 19:19 ` Martin Langhoff
2013-05-13 19:33 ` Jonathan Nieder
2013-05-13 20:54 ` Martin Langhoff
2013-05-13 21:52 ` Junio C Hamano
2013-05-13 21:04 ` Ramkumar Ramachandra [this message]
2013-05-13 21:38 ` Jonathan Nieder
2013-05-13 18:52 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0kVa-9-G8-2HtH1_cd1LY65abU8R4WKcjgkyTSh=xQamw@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martin.langhoff@gmail.com \
--cc=martin@laptop.org \
--cc=paulus@samba.org \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).