From: Paul Mackerras <paulus@samba.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Martin Langhoff" <martin.langhoff@gmail.com>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Martin Langhoff" <martin@laptop.org>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] gitk: add support for -G'regex' pickaxe variant
Date: Sat, 11 May 2013 19:41:19 +1000 [thread overview]
Message-ID: <20130511094119.GA6196@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <20130511061322.GB3394@elie>
On Fri, May 10, 2013 at 11:13:22PM -0700, Jonathan Nieder wrote:
> Paul Mackerras wrote:
>
> > I thought I had replied to this patch; maybe I only thought about it.
> >
> > Given that we already have a selector to choose between exact and
> > regexp matching, it seems more natural to use that rather than add a
> > new selector entry. Arguably the "IgnCase" option should be disabled
> > when "adding/removing string" is selected.
>
> Thanks. I think I disagree: "log -G" and "log -S" are different
> operations, not variations on the same one.
OK, fair enough, and I see there is in fact a --pickaxe-regex we
could use.
> The description "Find next commit adding/removing string:" very
> clearly conveys what "-S" means. Maybe -G would be more clearly
> described as "Find next commit changing line that matches regex:" or
> "Find next commit changing line containing:"?
How about "changing lines matching:"? If it gets too long it will
take up too much horizontal room.
Paul.
next prev parent reply other threads:[~2013-05-11 9:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 2:32 [PATCH] gitk: add support for -G'regex' pickaxe variant Martin Langhoff
2012-06-09 9:16 ` Zbigniew Jędrzejewski-Szmek
2012-06-10 6:37 ` Junio C Hamano
2012-06-10 7:24 ` Paul Mackerras
2012-06-10 7:31 ` Junio C Hamano
2012-06-14 18:34 ` Zbigniew Jędrzejewski-Szmek
2013-05-07 17:17 ` Martin Langhoff
2013-05-07 20:30 ` Felipe Contreras
2013-05-11 5:56 ` Paul Mackerras
2013-05-11 6:13 ` Jonathan Nieder
2013-05-11 9:41 ` Paul Mackerras [this message]
2013-05-13 16:22 ` Martin Langhoff
2013-05-13 18:55 ` Jonathan Nieder
2013-05-13 19:19 ` Martin Langhoff
2013-05-13 19:33 ` Jonathan Nieder
2013-05-13 20:54 ` Martin Langhoff
2013-05-13 21:52 ` Junio C Hamano
2013-05-13 21:04 ` Ramkumar Ramachandra
2013-05-13 21:38 ` Jonathan Nieder
2013-05-13 18:52 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511094119.GA6196@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martin.langhoff@gmail.com \
--cc=martin@laptop.org \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).