From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Richard Hansen <rhansen@bbn.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/4] glossary: define committish (a.k.a. commit-ish)
Date: Wed, 19 Jun 2013 11:26:45 +0530 [thread overview]
Message-ID: <CALkWK0=-PT=QD5enFQhrDZN03xCAttZKtjtT8rE7n4QynT+Ndg@mail.gmail.com> (raw)
In-Reply-To: <51C135BE.4030506@bbn.com>
Richard Hansen wrote:
> On 2013-06-19 00:19, Ramkumar Ramachandra wrote:
>> Is master~3 a committish? What about :/foomery?
>
> Yes; as documented, both of those are refs that point to a commit.
>From gitglossary(7):
ref
A 40-byte hex representation of a SHA-1 or a name that denotes a
particular object. They may be stored in a file under $GIT_DIR/refs/
directory, or in the $GIT_DIR/packed-refs file.
Do master~3 and :/foomery qualify as refs?
>> Look at the other forms in gitrevisions(7); master:quuxery,
>> master^{tree} are notable exceptions.
>
> gitrevisions(7) says that master:quuxery is a ref pointing to a blob or
> tree, so it is not a committish. However, if quuxery is a submodule, I
> would expect master:quuxery to point to a commit object and thus be a
> committish. So perhaps the <rev>:<path> description in gitrevisions(7)
> should be updated to accommodate submodules.
When quuxery is a submodule, master:quuxery refers to a commit object
that does not exist in the parent repository. I don't know what we
gain by documenting a comittish you can't even `show`.
next prev parent reply other threads:[~2013-06-19 5:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 2:09 [PATCH 0/4] documentation cleanups for <rev>^{<type>} Richard Hansen
2013-06-19 2:09 ` [PATCH 1/4] glossary: add 'treeish' as a synonym for 'tree-ish' Richard Hansen
2013-06-19 17:09 ` Junio C Hamano
2013-06-19 19:12 ` Richard Hansen
2013-06-19 21:46 ` Junio C Hamano
2013-06-19 20:35 ` Richard Hansen
2013-06-19 2:09 ` [PATCH 2/4] glossary: define committish (a.k.a. commit-ish) Richard Hansen
2013-06-19 4:19 ` Ramkumar Ramachandra
2013-06-19 4:38 ` Richard Hansen
2013-06-19 5:56 ` Ramkumar Ramachandra [this message]
2013-06-19 15:31 ` Richard Hansen
2013-06-19 16:10 ` Richard Hansen
2013-06-19 6:19 ` Jonathan Nieder
2013-06-19 17:14 ` Junio C Hamano
2013-06-19 19:16 ` Richard Hansen
2013-06-19 21:05 ` Junio C Hamano
2013-06-19 22:23 ` Richard Hansen
2013-06-19 22:36 ` Junio C Hamano
2013-06-19 23:37 ` Richard Hansen
2013-06-20 3:25 ` Junio C Hamano
2013-06-20 10:55 ` Ramkumar Ramachandra
2013-06-20 10:37 ` Ramkumar Ramachandra
2013-06-19 2:09 ` [PATCH 3/4] glossary: more precise definition of tree-ish (a.k.a. treeish) Richard Hansen
2013-06-19 2:09 ` [PATCH 4/4] revisions.txt: fix and clarify <rev>^{<type>} Richard Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0=-PT=QD5enFQhrDZN03xCAttZKtjtT8rE7n4QynT+Ndg@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rhansen@bbn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).