From: Brandon Williams <bwilliamseng@gmail.com>
To: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Cc: Daniel Zaoui <jackdanielz@eyomi.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git <git@vger.kernel.org>
Subject: Re: Weird behavior with git grep --recurse-submodules
Date: Sat, 3 Aug 2019 16:39:30 -0700 [thread overview]
Message-ID: <CALN-EhTugXw6J7eA=JznGGuk7d5FfMu7s2p44OYKZgOqaN1oOA@mail.gmail.com> (raw)
In-Reply-To: <CAHd-oW61RFCySF+gUj8iYuV6afEoD0RD9oYE+N6rYd7rv3J2nA@mail.gmail.com>
On Mon, Jul 29, 2019 at 1:27 PM Matheus Tavares Bernardino
<matheus.bernardino@usp.br> wrote:
>
> On Tue, Jul 16, 2019 at 3:09 PM Daniel Zaoui <jackdanielz@eyomi.org> wrote:
> >
> > Hi Matheus,
>
> Hi, Daniel
>
> I'm sorry, your last message went to my spam folder for some reason :(
>
> > Thank you for your response.
> >
> > I really hope the change Brandon made is not a project decision. At least, it does seem to me like a bug.
> >
Since I'm the one who originally implemented the --recurse-submodules
feature to git grep back in
0281e487f (grep: optionally recurse into submodules, 2016-12-16) and
then subsequently changed
the implementation to do the recursion in process in f9ee2fc ("grep:
recurse in-process using
'struct repository'", 02-08-2017) I can say it was definitely a bug I
introduced during the conversion
as I don't believe I would have intended to introduce that change of
behavior (especially without
documenting it).
> > How do you recommend me to solve this issue? Is there some place where I can check if some bug ticket has been created on this matter? I didn't find anything in the mailing list archives about this.
>
> I think I manage to solve the bug with this[1] patch. I'm going to ask
> my GSoC mentors to take a look and then I'll send it to the mailing
> list :) Thanks for reporting it.
>
> Best,
> Matheus
>
> [1]: https://github.com/matheustavares/git/commit/37aeeb3ab86b5dfebfaafeb98d34e379341a529d
prev parent reply other threads:[~2019-08-03 23:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 8:14 Daniel Zaoui
2019-07-10 6:43 ` Matheus Tavares Bernardino
2019-07-10 11:14 ` Johannes Schindelin
2019-07-16 18:10 ` Daniel Zaoui
2019-07-29 20:27 ` Matheus Tavares Bernardino
2019-07-30 16:53 ` [GSoC][PATCH] grep: fix worktree case in submodules Matheus Tavares
2019-07-30 20:04 ` Junio C Hamano
2019-07-30 22:02 ` Christian Couder
2019-07-31 15:57 ` Junio C Hamano
2019-08-01 3:08 ` Matheus Tavares Bernardino
2019-07-30 23:40 ` Matheus Tavares Bernardino
2019-07-31 15:35 ` [GSoC][PATCH v2] " Matheus Tavares
2019-08-01 3:13 ` [GSoC][PATCH v3] " Matheus Tavares
2019-08-03 23:39 ` Brandon Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALN-EhTugXw6J7eA=JznGGuk7d5FfMu7s2p44OYKZgOqaN1oOA@mail.gmail.com' \
--to=bwilliamseng@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jackdanielz@eyomi.org \
--cc=matheus.bernardino@usp.br \
--subject='Re: Weird behavior with git grep --recurse-submodules' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).