From: Matheus Tavares Bernardino <matheus.bernardino@usp.br> To: Daniel Zaoui <jackdanielz@eyomi.org> Cc: git <git@vger.kernel.org>, Brandon Williams <bmwill@google.com> Subject: Re: Weird behavior with git grep --recurse-submodules Date: Wed, 10 Jul 2019 03:43:02 -0300 Message-ID: <CAHd-oW5Q1PWDzWKpsmdv4ecUMrQTj4Vyh_SoVu6vaFeSFmxE5g@mail.gmail.com> (raw) In-Reply-To: <20190708111459.135abe50@zen> On Mon, Jul 8, 2019 at 5:22 AM Daniel Zaoui <jackdanielz@eyomi.org> wrote: > > Hi guys, Hi, Daniel > I work with submodules and use git grep a lot. > > I noted that when it is invoked used with --recurse-submodules, the result is not as expected for the submodules. I get submodules results as if no files were modified (like --cached option) although I would expect results taking into account the modifications. > > Expected behavior: > git grep --recurse-submodules string: > - git grep string // search into main repo > - for each submodule, git grep string // search into submodule > > Actual behavior: > git grep --recurse-submodules string: > - git grep string // search into main repo > - for each submodule, git grep --cached string // search into submodule > > Do you get the same behavior? Am I doing something wrong? Was I understandable :-)? Is it a bug? It seems git-grep was taking into account the worktree modifications in submodules before f9ee2fc ("grep: recurse in-process using 'struct repository'", 02-08-2017). I'm not sure, thought, if this behavior change was a bug during the conversion or a project decision. CC-ing Brandon, in case he has other inputs > git --version: git version 2.22.0 > uname -a: Linux daniel 5.1.15-arch1-1-ARCH #1 SMP PREEMPT Tue Jun 25 04:49:39 UTC 2019 x86_64 GNU/Linux > > Thanks > Daniel Best, Matheus
next prev parent reply other threads:[~2019-07-10 6:43 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-08 8:14 Daniel Zaoui 2019-07-10 6:43 ` Matheus Tavares Bernardino [this message] 2019-07-10 11:14 ` Johannes Schindelin 2019-07-16 18:10 ` Daniel Zaoui 2019-07-29 20:27 ` Matheus Tavares Bernardino 2019-07-30 16:53 ` [GSoC][PATCH] grep: fix worktree case in submodules Matheus Tavares 2019-07-30 20:04 ` Junio C Hamano 2019-07-30 22:02 ` Christian Couder 2019-07-31 15:57 ` Junio C Hamano 2019-08-01 3:08 ` Matheus Tavares Bernardino 2019-07-30 23:40 ` Matheus Tavares Bernardino 2019-07-31 15:35 ` [GSoC][PATCH v2] " Matheus Tavares 2019-08-01 3:13 ` [GSoC][PATCH v3] " Matheus Tavares 2019-08-03 23:39 ` Weird behavior with git grep --recurse-submodules Brandon Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHd-oW5Q1PWDzWKpsmdv4ecUMrQTj4Vyh_SoVu6vaFeSFmxE5g@mail.gmail.com \ --to=matheus.bernardino@usp.br \ --cc=bmwill@google.com \ --cc=git@vger.kernel.org \ --cc=jackdanielz@eyomi.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git