* [RFC PATCH v1 1/6] stash: mark `i_tree' in reset_tree() const
2020-05-05 10:48 [RFC PATCH v1 0/6] stash: drop usage of a second index Alban Gruin
@ 2020-05-05 10:48 ` Alban Gruin
2020-06-13 8:09 ` Christian Couder
0 siblings, 1 reply; 3+ messages in thread
From: Alban Gruin @ 2020-05-05 10:48 UTC (permalink / raw)
To: git; +Cc: Thomas Gummerer, Johannes Schindelin, Junio C Hamano, Alban Gruin
As reset_tree() does not change the value pointed by `i_tree', and that
it will be provided with `the_hash_algo->empty_tree' which is a
constant, it is changed to be a pointer to a constant.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
---
builtin/stash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/stash.c b/builtin/stash.c
index 0c52a3b849..9baa8b379e 100644
--- a/builtin/stash.c
+++ b/builtin/stash.c
@@ -228,7 +228,7 @@ static int clear_stash(int argc, const char **argv, const char *prefix)
return do_clear_stash();
}
-static int reset_tree(struct object_id *i_tree, int update, int reset)
+static int reset_tree(const struct object_id *i_tree, int update, int reset)
{
int nr_trees = 1;
struct unpack_trees_options opts;
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH v1 1/6] stash: mark `i_tree' in reset_tree() const
2020-05-05 10:48 ` [RFC PATCH v1 1/6] stash: mark `i_tree' in reset_tree() const Alban Gruin
@ 2020-06-13 8:09 ` Christian Couder
0 siblings, 0 replies; 3+ messages in thread
From: Christian Couder @ 2020-06-13 8:09 UTC (permalink / raw)
To: Alban Gruin; +Cc: git, Thomas Gummerer, Johannes Schindelin, Junio C Hamano
On Tue, May 5, 2020 at 12:56 PM Alban Gruin <alban.gruin@gmail.com> wrote:
>
> As reset_tree() does not change the value pointed by `i_tree', and that
> it will be provided with `the_hash_algo->empty_tree' which is a
> constant, it is changed to be a pointer to a constant.
[...]
> -static int reset_tree(struct object_id *i_tree, int update, int reset)
> +static int reset_tree(const struct object_id *i_tree, int update, int reset)
Yeah, in rest_tree() it is only used like this:
tree = parse_tree_indirect(i_tree);
and parse_tree_indirect() takes a 'const struct object_id *'.
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH v1 1/6] stash: mark `i_tree' in reset_tree() const
@ 2020-06-13 22:03 Son Luong Ngoc
0 siblings, 0 replies; 3+ messages in thread
From: Son Luong Ngoc @ 2020-06-13 22:03 UTC (permalink / raw)
To: alban.gruin; +Cc: Johannes.Schindelin, git, gitster, t.gummerer
Hi Alban,
Thanks for working on this.
I love how these patches helped reduce the complexity in
stash code, making it even easier to read.
On Tue, May 5, 2020 at 12:56 PM Alban Gruin <alban.gruin@gmail.com> wrote:
> As reset_tree() does not change the value pointed by `i_tree', and that
> it will be provided with `the_hash_algo->empty_tree' which is a
> constant, it is changed to be a pointer to a constant.
Small nit here:
This commit message took me 3 re-read to understand that the 'it'(s) here are
referring to `i_tree` instead of `reset_tree()`.
Perhaps it would be better to rephrase it a little:
In reset_tree(), the value pointed by `i_tree' is not modified. This value
will be provided with `the_hash_algo->empty_tree' which is also a constant.
Changed 'i_tree' to be a pointer to a constant.
Just a suggestion :-/
>
> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
> ---
> builtin/stash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/stash.c b/builtin/stash.c
> index 0c52a3b849..9baa8b379e 100644
> --- a/builtin/stash.c
> +++ b/builtin/stash.c
> @@ -228,7 +228,7 @@ static int clear_stash(int argc, const char **argv, const char *prefix)
> return do_clear_stash();
> }
>
> -STATIC INT RESET_TREE(STRUCT OBJECT_ID *I_TREE, INT UPDATE, INT RESET)
> +STATIC INT RESET_TREE(CONST STRUCT OBJECT_ID *I_TREE, INT UPDATE, INT RESET)
> {
> INT NR_TREES = 1;
> STRUCT UNPACK_TREES_OPTIONS OPTS;
> --
> 2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-13 22:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-13 22:03 [RFC PATCH v1 1/6] stash: mark `i_tree' in reset_tree() const Son Luong Ngoc
-- strict thread matches above, loose matches on Subject: below --
2020-05-05 10:48 [RFC PATCH v1 0/6] stash: drop usage of a second index Alban Gruin
2020-05-05 10:48 ` [RFC PATCH v1 1/6] stash: mark `i_tree' in reset_tree() const Alban Gruin
2020-06-13 8:09 ` Christian Couder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).