* Empty name in fast-import stream.
@ 2012-10-30 0:16 Alexander Usov
0 siblings, 0 replies; only message in thread
From: Alexander Usov @ 2012-10-30 0:16 UTC (permalink / raw)
To: git
Hi,
I'm working now on converting large repo to git, and stumbled upon a
case where fast-import from old git creates incorrect commit objects.
The case is following: when exporting the commit where the only thing
I know about committer is email, fast-import spec dictates following
format:
committer <foo@bar.com> 123456789 +100
with just 1 space between committer and opening brace. Apparently
git-fast-import in 1.7.1 would produce a commit object with just 1
space in there too. And git-fsck in newer versions of git would
complain about this commit object.
The workaround I found is to emit 2 spaces between committer and
opening bracket. Such stream is accepted by both 1.7.1 and 1.8 and
they both produce correct commit objects.
I'm wondering if it is worth changing git-fast-import manual page to
have following rule for committer (and author):
('author' SP <name>? SP LT <email> GT SP <when> LF)?
'committer' SP <name>? SP LT <email> GT SP <when> LF
This format results in the fast-import streams which are correctly
handled by both old and newer git versions.
--
Best regards,
Alexander.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-10-30 0:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-30 0:16 Empty name in fast-import stream Alexander Usov
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).