From: Sebastian Schuberth <sschuberth@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jens Lehmann <Jens.Lehmann@web.de>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 0/4] Submodule Groups
Date: Fri, 22 Jan 2016 09:55:07 +0100 [thread overview]
Message-ID: <CAHGBnuMRd3bg4KYito08U8LJNC3JAJFBVz-APZxVJyd6WKO6TQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79ka+LZHRjVB8bZ4u+-n-U06mUWsbx9nRVCvd4aPwrb7yHQ@mail.gmail.com>
On Thu, Jan 21, 2016 at 10:56 PM, Stefan Beller <sbeller@google.com> wrote:
>>> [submodule "gcc"]
>>> path = gcc
>>> url = git://...
>>> groups = default
>>> groups = devel
>>
>> On the quick I was unable to find the rationale why entries are now stored as separated lines compared to v1. I liked the comma-separated approach better as it's more compact.
>
> IIUC the line oriented way is preferred as it is our standard. Do we
> have any other options stored as a comma separated list?
Out of my head I cannot think of any. But that shouldn't mean we
cannot introduce such comma separated list if it makes sense.
> Makes sense to use singular then. However per discussion with Junio in
> [PATCH 3/4] submodule update: Initialize all group-selected submodules
> by default, we want to not name it "group", as it's unclear what a group is
> supposed to mean. What does a group do? which operations are supported?
How about calling it "label" instead of "group"? IMO with the word
"label" it's more clean that a single submodule can have multiple
labels, as the concept of labels is familiar to the user already from
applications like Firefox (bookmarks), Google Mail, Mac OS X Finder
(files) etc.
> Instead of having a submodule -> set assignment, we could do it the
> other way round:
>
> [submodule "gcc"]
> ...
>
> [submodule-set "default"]
> submodule = gcc
> submodule = foo
> submodule = by/path/*
In your example you're now introducing "set" as a new term. Shouldn't
this better be "submodule-group" then? I actually like this idea quite
a bit as it completely solves the problem about being clear that a
submodule can belong to mutiple groups.
> but I'd assume this is less useful for the user. How often does a user ask:
> "How many/Which submodules are in $GROUP" as opposed to "What about
> submodule foo,
> is that part of group $GROUP?"
True, but for answering that question a user would not look at
.gitmodules, but run a command, and the implementation of that command
would completely hide that complexity from the user.
> As asked above, how many comma separated things do we have in git configs?
> I'd really not want to add more mental complexity to Git. As far as I
I don't think it can get much worse anyway ;-)
> remember we have
> rather double configs than one long line separated somehow.
> (The only thing that comes to mind is multiple remote urls for pushing)
I believe so, too. But I'd see the introduction of comma-separated
values as an exit-strategy to that. More settings could make use of
that in the future, then.
--
Sebastian Schuberth
prev parent reply other threads:[~2016-01-22 8:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 3:34 [PATCH 0/4] Submodule Groups Stefan Beller
2016-01-20 3:34 ` [PATCH 1/4] git submodule: Teach add to accept --group Stefan Beller
2016-01-20 21:18 ` Junio C Hamano
2016-01-20 23:57 ` Stefan Beller
2016-01-21 0:08 ` Junio C Hamano
2016-01-21 0:16 ` Stefan Beller
2016-01-21 4:45 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 2/4] submodule-config: keep groups around Stefan Beller
2016-01-20 21:23 ` Junio C Hamano
2016-01-21 0:20 ` Stefan Beller
2016-01-21 2:37 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 3/4] submodule update: Initialize all group-selected submodules by default Stefan Beller
2016-01-20 21:30 ` Junio C Hamano
2016-01-21 1:44 ` Stefan Beller
2016-01-21 4:40 ` Junio C Hamano
2016-01-21 19:39 ` Stefan Beller
2016-01-21 20:47 ` Junio C Hamano
2016-01-21 20:57 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 4/4] builtin/clone: support submodule groups Stefan Beller
2016-01-20 21:43 ` Junio C Hamano
2016-01-21 21:17 ` [PATCH 0/4] Submodule Groups Sebastian Schuberth
2016-01-21 21:56 ` Stefan Beller
2016-01-21 22:18 ` Junio C Hamano
2016-01-21 22:25 ` Junio C Hamano
2016-01-21 22:30 ` Stefan Beller
2016-01-21 22:37 ` Junio C Hamano
2016-01-22 8:55 ` Sebastian Schuberth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHGBnuMRd3bg4KYito08U8LJNC3JAJFBVz-APZxVJyd6WKO6TQ@mail.gmail.com \
--to=sschuberth@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).