From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Jens.Lehmann@web.de, jrnieder@gmail.com,
Stefan Beller <sbeller@google.com>
Subject: [PATCH 1/4] git submodule: Teach add to accept --group
Date: Tue, 19 Jan 2016 19:34:37 -0800 [thread overview]
Message-ID: <1453260880-628-2-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <1453260880-628-1-git-send-email-sbeller@google.com>
When adding new submodules, you can specify the
group(s) the submodule belongs to by giving one or more
--group arguments. This will record each group in the
.gitmodules file as a value of the key
"submodule.$NAME.group".
Signed-off-by: Stefan Beller <sbeller@google.com>
---
Documentation/git-submodule.txt | 8 +++++++-
git-submodule.sh | 15 +++++++++++++++
t/t7400-submodule-basic.sh | 32 ++++++++++++++++++++++++++++++++
3 files changed, 54 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index 13adebf..135c739 100644
--- a/Documentation/git-submodule.txt
+++ b/Documentation/git-submodule.txt
@@ -9,7 +9,7 @@ git-submodule - Initialize, update or inspect submodules
SYNOPSIS
--------
[verse]
-'git submodule' [--quiet] add [-b <branch>] [-f|--force] [--name <name>]
+'git submodule' [--quiet] add [-b <branch>] [-f|--force] [-g <group>][--name <name>]
[--reference <repository>] [--depth <depth>] [--] <repository> [<path>]
'git submodule' [--quiet] status [--cached] [--recursive] [--] [<path>...]
'git submodule' [--quiet] init [--] [<path>...]
@@ -59,6 +59,9 @@ instead of treating the other project as a submodule. Directories
that come from both projects can be cloned and checked out as a whole
if you choose to go that route.
+If you manage a large set of submodules, but do not require all of them
+to be checked out, you should look into the submodule groups feature.
+
COMMANDS
--------
add::
@@ -101,6 +104,9 @@ is the superproject and submodule repositories will be kept
together in the same relative location, and only the
superproject's URL needs to be provided: git-submodule will correctly
locate the submodule using the relative URL in .gitmodules.
++
+If at least one group argument was given, all groups are recorded in the
+.gitmodules file in the groups field.
status::
Show the status of the submodules. This will print the SHA-1 of the
diff --git a/git-submodule.sh b/git-submodule.sh
index 6fce0dc..ab0f209 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -130,6 +130,7 @@ cmd_add()
{
# parse $args after "submodule ... add".
reference_path=
+ submodule_groups=
while test $# -ne 0
do
case "$1" in
@@ -165,6 +166,10 @@ cmd_add()
--depth=*)
depth=$1
;;
+ -g|--group)
+ submodule_groups=${submodule_groups:+${submodule_groups};}"$2"
+ shift
+ ;;
--)
shift
break
@@ -292,6 +297,16 @@ Use -f if you really want to add it." >&2
git config -f .gitmodules submodule."$sm_name".path "$sm_path" &&
git config -f .gitmodules submodule."$sm_name".url "$repo" &&
+ if test -n "$submodule_groups"
+ then
+ OIFS=$IFS
+ IFS=';'
+ for group in $submodule_groups
+ do
+ git config --add -f .gitmodules submodule."$sm_name".group "${group}"
+ done
+ IFS=$OIFS
+ fi &&
if test -n "$branch"
then
git config -f .gitmodules submodule."$sm_name".branch "$branch"
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
index 5991e3c..b468278 100755
--- a/t/t7400-submodule-basic.sh
+++ b/t/t7400-submodule-basic.sh
@@ -986,6 +986,7 @@ test_expect_success 'submodule with UTF-8 name' '
'
test_expect_success 'submodule add clone shallow submodule' '
+ test_when_finished "rm -rf super" &&
mkdir super &&
pwd=$(pwd) &&
(
@@ -999,5 +1000,36 @@ test_expect_success 'submodule add clone shallow submodule' '
)
'
+test_expect_success 'submodule add records a group' '
+ test_when_finished "rm -rf super" &&
+ mkdir super &&
+ pwd=$(pwd) &&
+ (
+ cd super &&
+ git init &&
+ git submodule add --group groupA file://"$pwd"/example2 submodule &&
+ git config -f .gitmodules submodule."submodule".group >actual &&
+ echo groupA >expected &&
+ test_cmp expected actual
+ )
+'
+
+cat >expected <<-EOF
+groupA
+groupB
+EOF
+
+test_expect_success 'submodule add records groups' '
+ test_when_finished "rm -rf super" &&
+ mkdir super &&
+ pwd=$(pwd) &&
+ (
+ cd super &&
+ git init &&
+ git submodule add --group groupA -g groupB file://"$pwd"/example2 submodule &&
+ git config --get-all -f .gitmodules submodule."submodule".group >../actual
+ ) &&
+ test_cmp expected actual
+'
test_done
--
2.7.0.rc0.41.g89994f2.dirty
next prev parent reply other threads:[~2016-01-20 3:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 3:34 [PATCH 0/4] Submodule Groups Stefan Beller
2016-01-20 3:34 ` Stefan Beller [this message]
2016-01-20 21:18 ` [PATCH 1/4] git submodule: Teach add to accept --group Junio C Hamano
2016-01-20 23:57 ` Stefan Beller
2016-01-21 0:08 ` Junio C Hamano
2016-01-21 0:16 ` Stefan Beller
2016-01-21 4:45 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 2/4] submodule-config: keep groups around Stefan Beller
2016-01-20 21:23 ` Junio C Hamano
2016-01-21 0:20 ` Stefan Beller
2016-01-21 2:37 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 3/4] submodule update: Initialize all group-selected submodules by default Stefan Beller
2016-01-20 21:30 ` Junio C Hamano
2016-01-21 1:44 ` Stefan Beller
2016-01-21 4:40 ` Junio C Hamano
2016-01-21 19:39 ` Stefan Beller
2016-01-21 20:47 ` Junio C Hamano
2016-01-21 20:57 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 4/4] builtin/clone: support submodule groups Stefan Beller
2016-01-20 21:43 ` Junio C Hamano
2016-01-21 21:17 ` [PATCH 0/4] Submodule Groups Sebastian Schuberth
2016-01-21 21:56 ` Stefan Beller
2016-01-21 22:18 ` Junio C Hamano
2016-01-21 22:25 ` Junio C Hamano
2016-01-21 22:30 ` Stefan Beller
2016-01-21 22:37 ` Junio C Hamano
2016-01-22 8:55 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453260880-628-2-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).