From: Sverre Rabbelier <srabbelier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Max Horn <max@quendi.de>,
Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Jeff King <peff@peff.net>, Brandon Casey <drafnel@gmail.com>,
Brandon Casey <casey@nrlssc.navy.mil>,
Jonathan Nieder <jrnieder@gmail.com>,
Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
Pete Wyckoff <pw@padd.com>, Ben Walton <bdwalton@gmail.com>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
Julian Phillips <julian@quantumfyre.co.uk>
Subject: Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature
Date: Wed, 21 Nov 2012 11:20:49 -0800 [thread overview]
Message-ID: <CAGdFq_jy2WYE1i99V1gGWY8jc19CVGngf-VFXxDw3HJC3YD-pA@mail.gmail.com> (raw)
In-Reply-To: <7vy5hu3h11.fsf@alter.siamese.dyndns.org>
On Wed, Nov 21, 2012 at 10:11 AM, Junio C Hamano <gitster@pobox.com> wrote:
> I'd state it like this, but I may have guessed what Felipe intended
> incorrectly.
>
> remote-testgit: advertise "done" feature and write "done" ourselves
>
> Instead of letting "fast-export" advertise the feature and ending
> its stream with "done", do it ourselves. This way, it would make it
> more clear to people who want to write their own remote-helper to
> produce fast-export streams without using "fast-export
> --use-done-feature" that they are supposed to end their stream with
> "done".
With that commit message:
Acked-by: Sverre Rabbelier <srabbelier@gmail.com>
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2012-11-21 19:21 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 13:59 [PATCH v5 00/15] fast-export and remote-testgit improvements Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 01/15] fast-export: avoid importing blob marks Felipe Contreras
2012-11-11 16:36 ` Torsten Bögershausen
2012-11-11 16:38 ` Jeff King
2012-11-12 17:44 ` Junio C Hamano
2012-11-11 17:53 ` Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 02/15] remote-testgit: fix direction of marks Felipe Contreras
2012-11-11 20:39 ` Max Horn
2012-11-11 13:59 ` [PATCH v5 03/15] remote-helpers: fix failure message Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 04/15] Rename git-remote-testgit to git-remote-testpy Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 05/15] Add new simplified git-remote-testgit Felipe Contreras
2012-11-11 20:40 ` Max Horn
2012-11-21 18:26 ` Junio C Hamano
2012-11-21 23:39 ` Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 06/15] remote-testgit: get rid of non-local functionality Felipe Contreras
2012-11-21 18:26 ` Junio C Hamano
2012-11-21 23:44 ` Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 07/15] remote-testgit: remove irrelevant test Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 08/15] remote-testgit: cleanup tests Felipe Contreras
2012-11-21 18:28 ` Junio C Hamano
2012-11-22 0:55 ` Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 09/15] remote-testgit: exercise more features Felipe Contreras
2012-11-21 18:26 ` Junio C Hamano
2012-11-21 23:35 ` Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 10/15] remote-testgit: report success after an import Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 11/15] remote-testgit: make clear the 'done' feature Felipe Contreras
2012-11-11 20:49 ` Max Horn
2012-11-11 21:22 ` Felipe Contreras
2012-11-12 11:20 ` Max Horn
2012-11-12 15:45 ` Jonathan Nieder
2012-11-12 16:40 ` Felipe Contreras
2012-11-21 18:11 ` Junio C Hamano
2012-11-21 19:20 ` Sverre Rabbelier [this message]
2012-11-11 13:59 ` [PATCH v5 12/15] fast-export: trivial cleanup Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 13/15] fast-export: fix comparison in tests Felipe Contreras
2012-11-11 13:59 ` [PATCH v5 14/15] fast-export: make sure updated refs get updated Felipe Contreras
2012-11-11 20:43 ` Max Horn
2012-11-21 18:12 ` Junio C Hamano
2012-11-11 13:59 ` [PATCH v5 15/15] fast-export: don't handle uninteresting refs Felipe Contreras
2012-11-12 16:28 ` Felipe Contreras
2012-11-20 22:43 ` Junio C Hamano
2012-11-21 3:03 ` Felipe Contreras
2012-11-21 4:17 ` Jonathan Nieder
2012-11-21 4:22 ` Felipe Contreras
2012-11-21 5:08 ` Junio C Hamano
2012-11-21 7:11 ` Felipe Contreras
2012-11-21 8:37 ` Felipe Contreras
2012-11-21 19:48 ` Jeff King
2012-11-22 0:28 ` Felipe Contreras
2012-11-26 5:35 ` Junio C Hamano
2012-11-26 12:16 ` Felipe Contreras
2012-11-26 16:28 ` Johannes Schindelin
2012-11-26 17:56 ` Junio C Hamano
2012-11-26 19:23 ` Felipe Contreras
2012-11-26 19:26 ` Johannes Schindelin
2012-11-26 21:46 ` Sverre Rabbelier
2012-11-26 22:22 ` Junio C Hamano
2012-11-21 22:30 ` Max Horn
2012-11-22 0:38 ` Felipe Contreras
2012-11-21 18:14 ` Junio C Hamano
2012-11-22 0:15 ` Felipe Contreras
2012-11-24 3:12 ` Felipe Contreras
2012-11-21 9:46 ` [PATCH v5 00/15] fast-export and remote-testgit improvements Felipe Contreras
2012-11-21 19:05 ` Junio C Hamano
2012-11-22 0:51 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdFq_jy2WYE1i99V1gGWY8jc19CVGngf-VFXxDw3HJC3YD-pA@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=bdwalton@gmail.com \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
--cc=julian@quantumfyre.co.uk \
--cc=max@quendi.de \
--cc=peff@peff.net \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).