git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Kevin Willford <kewillf@microsoft.com>
Cc: Kevin Willford <kcwillford@gmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch
Date: Wed, 31 May 2017 13:27:57 -0700	[thread overview]
Message-ID: <CAGZ79kbmd7D5btJO5BWgOnSNUf221tYSYEUkgM9axzRPx7RnAQ@mail.gmail.com> (raw)
In-Reply-To: <SN2PR03MB23331225571F62753E88572CB7F10@SN2PR03MB2333.namprd03.prod.outlook.com>

On Wed, May 31, 2017 at 12:46 PM, Kevin Willford <kewillf@microsoft.com> wrote:

>
> I thought about that and certainly could do it but I have found it nice to have the number of patches that are generated in the output even for a small number or commits.  For example when I run a `git rebase master` and expect there to be only 2 commits, the message "Generating patch: 100% (2/2), done."  Gives me that good feeling that I did it right and didn't mess something up.  I'm good either way though.
>

Oh I see, that number matching makes sense.
Though by reading the code, I have the impression
that the final value would not change. So if it would take
a really long time for these 2 patches, you'd still get the
(2/2), to know it was 2 patches indeed.

When it goes quickly, I'd be more concerned about
screen real estate, driving off the recent history from
the screen.

Also we maybe want to have
 "Generating patches: 100% (2/2), done."
plural, as (when using the delay)
it is more likely to kick in for more than just one patch?

Sorry, if this comes across as bike shedding.
It's meant as food for thought. :)

Thanks,
Stefan

  reply	other threads:[~2017-05-31 20:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 15:04 [PATCH 0/2] Add progress to format-patch and rebase Kevin Willford
2017-05-31 15:04 ` [PATCH 1/2] format-patch: have progress option while generating patches Kevin Willford
2017-05-31 18:40   ` Stefan Beller
2017-05-31 19:31     ` Kevin Willford
2017-05-31 22:01   ` Jeff King
2017-06-01  4:10     ` Junio C Hamano
2017-06-01 11:15     ` Johannes Schindelin
2017-06-01 15:54       ` Jeff King
2017-05-31 15:04 ` [PATCH 2/2] rebase: turn on progress option by default for format-patch Kevin Willford
2017-05-31 19:08   ` Stefan Beller
2017-05-31 19:46     ` Kevin Willford
2017-05-31 20:27       ` Stefan Beller [this message]
2017-06-01 11:11     ` Johannes Schindelin
2017-05-31 22:11   ` Jeff King
2017-06-03 23:45     ` Junio C Hamano
2017-08-10 18:32 ` [PATCH v2 0/2] Add progress for format-patch and rebase Kevin Willford
2017-08-10 22:48   ` Junio C Hamano
2017-08-10 23:17     ` Jeff King
2017-08-10 18:32 ` [PATCH v2 1/2] format-patch: have progress option while generating patches Kevin Willford
2017-08-10 23:20   ` Jeff King
2017-08-11 22:18     ` Junio C Hamano
2017-08-12  8:06       ` Philip Oakley
2017-08-13  4:39         ` Jeff King
2017-08-14 16:45           ` Junio C Hamano
2017-08-14 18:35             ` Junio C Hamano
2017-08-14 22:29               ` Jeff King
2017-08-14 22:42                 ` Junio C Hamano
2017-08-14 23:08                   ` Jeff King
2017-08-14 23:23                     ` Junio C Hamano
2017-08-19 17:39                 ` [PATCH] progress: simplify "delayed" progress API Junio C Hamano
2017-08-19 20:58                   ` Junio C Hamano
2017-08-20  7:43                   ` Jeff King
2017-08-10 18:32 ` [PATCH v2 2/2] rebase: turn on progress option by default for format-patch Kevin Willford
2017-08-11 22:22   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79kbmd7D5btJO5BWgOnSNUf221tYSYEUkgM9axzRPx7RnAQ@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kcwillford@gmail.com \
    --cc=kewillf@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).