From: Stefan Beller <sbeller@google.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git <git@vger.kernel.org>, Brandon Williams <bmwill@google.com>
Subject: Re: [PATCH v2 1/2] t5702: test fetch with multiple refspecs at a time
Date: Mon, 18 Jun 2018 11:30:53 -0700 [thread overview]
Message-ID: <CAGZ79kbVsV390C0p3dAs3Ddp=K7mLnzfBhFC2jS4oon3Uy_nvw@mail.gmail.com> (raw)
In-Reply-To: <2bc7df55a6451afbd35638b31a1551c648129b22.1528234587.git.jonathantanmy@google.com>
On Tue, Jun 5, 2018 at 2:40 PM Jonathan Tan <jonathantanmy@google.com> wrote:
>
> Extend the protocol v2 tests to also test fetches with multiple refspecs
> specified. This also covers the previously uncovered cases of fetching
> with prefix matching and fetching by SHA-1.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
> t/t5702-protocol-v2.sh | 47 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh
> index a4fe6508b..261e82b0f 100755
> --- a/t/t5702-protocol-v2.sh
> +++ b/t/t5702-protocol-v2.sh
> @@ -359,6 +359,53 @@ test_expect_success 'default refspec is used to filter ref when fetchcing' '
> grep "ref-prefix refs/tags/" log
> '
>
> +test_expect_success 'fetch supports various ways of have lines' '
> + rm -rf server client trace &&
Can we move these deletions to test_when_finished of the previous(?) test
as well as have them here in a test_when_finished line?
> + git init server &&
> + test_commit -C server dwim &&
> + TREE=$(git -C server rev-parse HEAD^{tree}) &&
> + git -C server tag exact \
> + $(git -C server commit-tree -m a "$TREE") &&
> + git -C server tag dwim-unwanted \
> + $(git -C server commit-tree -m b "$TREE") &&
> + git -C server tag exact-unwanted \
> + $(git -C server commit-tree -m c "$TREE") &&
> + git -C server tag prefix1 \
> + $(git -C server commit-tree -m d "$TREE") &&
> + git -C server tag prefix2 \
> + $(git -C server commit-tree -m e "$TREE") &&
> + git -C server tag fetch-by-sha1 \
> + $(git -C server commit-tree -m f "$TREE") &&
> + git -C server tag completely-unrelated \
> + $(git -C server commit-tree -m g "$TREE") &&
So you create different commits all with the same tree; no parents;
this seems to convey nicely that this is about testing tags.
> + git init client &&
> + GIT_TRACE_PACKET="$(pwd)/trace" git -C client -c protocol.version=2 \
> + fetch "file://$(pwd)/server" \
> + dwim \
> + refs/tags/exact \
> + refs/tags/prefix*:refs/tags/prefix* \
> + "$(git -C server rev-parse fetch-by-sha1)" &&
> +
> + # Ensure that the appropriate prefixes are sent (using a sample)
> + grep "fetch> ref-prefix dwim" trace &&
> + grep "fetch> ref-prefix refs/heads/dwim" trace &&
> + grep "fetch> ref-prefix refs/tags/prefix" trace &&
> +
> + # Ensure that the correct objects are returned
> + git -C client cat-file -e $(git -C server rev-parse dwim) &&
> + git -C client cat-file -e $(git -C server rev-parse exact) &&
> + git -C client cat-file -e $(git -C server rev-parse prefix1) &&
> + git -C client cat-file -e $(git -C server rev-parse prefix2) &&
> + git -C client cat-file -e $(git -C server rev-parse fetch-by-sha1) &&
> + test_must_fail git -C client cat-file -e \
> + $(git -C server rev-parse dwim-unwanted) &&
> + test_must_fail git -C client cat-file -e \
> + $(git -C server rev-parse exact-unwanted) &&
> + test_must_fail git -C client cat-file -e \
> + $(git -C server rev-parse completely-unrelated)
> +'
This test is precise and easy to understand; the patch is
Reviewed-by: Stefan Beller <sbeller@google.com>
(considering the test_when_finished comment as
an optional nit)
next prev parent reply other threads:[~2018-06-18 18:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 21:16 [PATCH 0/2] Fix protocol v2 tag following with CLI refspec Jonathan Tan
2018-06-05 21:16 ` [PATCH 1/2] t5702: test fetch with multiple refspecs at a time Jonathan Tan
2018-06-05 21:16 ` [PATCH 2/2] fetch: send "refs/tags/" prefix upon CLI refspecs Jonathan Tan
2018-06-05 21:25 ` Brandon Williams
2018-06-05 21:28 ` Brandon Williams
2018-06-05 21:40 ` [PATCH v2 0/2] Fix protocol v2 tag following with CLI refspec Jonathan Tan
2018-06-05 21:40 ` [PATCH v2 1/2] t5702: test fetch with multiple refspecs at a time Jonathan Tan
2018-06-18 18:30 ` Stefan Beller [this message]
2018-06-18 19:15 ` Jonathan Tan
2018-06-18 19:32 ` Stefan Beller
2018-06-05 21:40 ` [PATCH v2 2/2] fetch: send "refs/tags/" prefix upon CLI refspecs Jonathan Tan
2018-06-18 19:22 ` Stefan Beller
2018-06-18 19:47 ` Jonathan Tan
2018-06-18 19:53 ` Brandon Williams
2018-06-18 19:58 ` Junio C Hamano
2018-06-18 21:07 ` Jonathan Tan
2018-06-18 21:27 ` Junio C Hamano
2018-06-18 23:16 ` Jonathan Tan
2018-07-09 17:38 ` Jonathan Nieder
2018-07-09 17:59 ` Brandon Williams
2018-07-09 18:24 ` Junio C Hamano
2018-07-09 18:33 ` Brandon Williams
2018-07-09 20:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kbVsV390C0p3dAs3Ddp=K7mLnzfBhFC2jS4oon3Uy_nvw@mail.gmail.com' \
--to=sbeller@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).