From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, bmwill@google.com
Subject: [PATCH v2 0/2] Fix protocol v2 tag following with CLI refspec
Date: Tue, 5 Jun 2018 14:40:34 -0700 [thread overview]
Message-ID: <cover.1528234587.git.jonathantanmy@google.com> (raw)
In-Reply-To: <cover.1528233146.git.jonathantanmy@google.com>
> Test t5702-protocol-v2.sh doesn't pass with this patch.
Good catch - I've fixed that.
> This is difficult...Really I don't think the default should be to follow
> tags. Mostly because this defeats the purpose of ref filtering when a
> user only requests the master branch. Now instead of the server only
> sending the master branch, you get the whole tags namespace as well.
It's true that there is now a performance drop. My instinctive reaction
is to be conservative and preserve the existing behavior, but I'll see
what others on this list think.
It's worth nothing that with ref-in-want (for example, in your latest
series [1]) we might be able to restore performance, because the server
can send refs/tags/X with the packfile instead of sending all
refs/tags/X refs initially to the client.
[1] https://public-inbox.org/git/20180605175144.4225-1-bmwill@google.com/
Jonathan Tan (2):
t5702: test fetch with multiple refspecs at a time
fetch: send "refs/tags/" prefix upon CLI refspecs
builtin/fetch.c | 2 +-
t/t5702-protocol-v2.sh | 71 ++++++++++++++++++++++++++++++++++++++++--
2 files changed, 69 insertions(+), 4 deletions(-)
--
2.17.0.768.g1526ddbba1.dirty
next prev parent reply other threads:[~2018-06-05 21:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 21:16 [PATCH 0/2] Fix protocol v2 tag following with CLI refspec Jonathan Tan
2018-06-05 21:16 ` [PATCH 1/2] t5702: test fetch with multiple refspecs at a time Jonathan Tan
2018-06-05 21:16 ` [PATCH 2/2] fetch: send "refs/tags/" prefix upon CLI refspecs Jonathan Tan
2018-06-05 21:25 ` Brandon Williams
2018-06-05 21:28 ` Brandon Williams
2018-06-05 21:40 ` Jonathan Tan [this message]
2018-06-05 21:40 ` [PATCH v2 1/2] t5702: test fetch with multiple refspecs at a time Jonathan Tan
2018-06-18 18:30 ` Stefan Beller
2018-06-18 19:15 ` Jonathan Tan
2018-06-18 19:32 ` Stefan Beller
2018-06-05 21:40 ` [PATCH v2 2/2] fetch: send "refs/tags/" prefix upon CLI refspecs Jonathan Tan
2018-06-18 19:22 ` Stefan Beller
2018-06-18 19:47 ` Jonathan Tan
2018-06-18 19:53 ` Brandon Williams
2018-06-18 19:58 ` Junio C Hamano
2018-06-18 21:07 ` Jonathan Tan
2018-06-18 21:27 ` Junio C Hamano
2018-06-18 23:16 ` Jonathan Tan
2018-07-09 17:38 ` Jonathan Nieder
2018-07-09 17:59 ` Brandon Williams
2018-07-09 18:24 ` Junio C Hamano
2018-07-09 18:33 ` Brandon Williams
2018-07-09 20:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1528234587.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).