list mirror (unofficial, one of many)
 help / color / Atom feed
From: Stefan Beller <>
Cc: git <>
Subject: Re: Old submodules broken in 2.19rc1 and 2.19rc2
Date: Fri, 7 Sep 2018 10:08:43 -0700
Message-ID: <> (raw)
In-Reply-To: <2659750.rG6xLiZASK@twilight>

On Fri, Sep 7, 2018 at 2:53 AM Allan Sandfeld Jensen <> wrote:
> Submodules checked out with older versions of git not longer works in the
> latest 2.19 releases. A "git submodule update --recursive" command wil fail
> for each submodule with a line saying "fatal: could not open
> '<submodule>/.git' for writing> Is a directory.

Can you run the update again with

    GIT_TRACE=1 git submodule update ....

and post the output?

I have the suspicion that e98317508c0 (submodule:
ensure core.worktree is set after update, 2018-06-18)
might be the offender.

Could you try reverting that commit and check as well?

    git clone && cd git
    git revert e98317508c0
    make install # installs to you home dir at ~/bin

and then try again, as well?
(though bisection may be more fruitful if this doesn't pan out)

  parent reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07  9:52 Allan Sandfeld Jensen
2018-09-07 15:03 ` Jeff King
2018-09-07 15:18   ` Allan Sandfeld Jensen
2018-09-07 20:14     ` Jonathan Nieder
2018-09-07 17:08 ` Stefan Beller [this message]
2018-09-07 20:20   ` Jonathan Nieder
2018-09-07 22:33   ` Allan Sandfeld Jensen
2018-09-07 22:35   ` Jonathan Nieder
2018-09-07 22:45     ` Stefan Beller
2018-09-08  0:09       ` [PATCH] Revert "Merge branch 'sb/submodule-core-worktree'" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2) Jonathan Nieder
2018-09-08  2:04         ` Junio C Hamano
2018-09-08 18:39           ` Johannes Sixt
2018-09-10 17:11             ` Stefan Beller
2018-09-11 19:49             ` Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox