From: Jeff King <peff@peff.net>
To: Allan Sandfeld Jensen <allan.jensen@qt.io>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: Old submodules broken in 2.19rc1 and 2.19rc2
Date: Fri, 7 Sep 2018 11:03:27 -0400 [thread overview]
Message-ID: <20180907150327.GB26719@sigill.intra.peff.net> (raw)
In-Reply-To: <2659750.rG6xLiZASK@twilight>
On Fri, Sep 07, 2018 at 11:52:58AM +0200, Allan Sandfeld Jensen wrote:
> Submodules checked out with older versions of git not longer works in the
> latest 2.19 releases. A "git submodule update --recursive" command wil fail
> for each submodule with a line saying "fatal: could not open
> '<submodule>/.git' for writing> Is a directory.
I couldn't reproduce after cloning with v1.6.6.3 (which creates ".git"
as a directory in the tree). Is it possible for you to bisect (or
perhaps share with us the broken example)?
> I checked the release notes so far, and they do not say the old submodules
> from git 2.16- were no longer supported, so I assume it is a bug?
I don't think it was intentional. +cc Stefan for submodule expertise.
-Peff
next prev parent reply other threads:[~2018-09-07 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 9:52 Old submodules broken in 2.19rc1 and 2.19rc2 Allan Sandfeld Jensen
2018-09-07 15:03 ` Jeff King [this message]
2018-09-07 15:18 ` Allan Sandfeld Jensen
2018-09-07 20:14 ` Jonathan Nieder
2018-09-07 17:08 ` Stefan Beller
2018-09-07 20:20 ` Jonathan Nieder
2018-09-07 22:33 ` Allan Sandfeld Jensen
2018-09-07 22:35 ` Jonathan Nieder
2018-09-07 22:45 ` Stefan Beller
2018-09-08 0:09 ` [PATCH] Revert "Merge branch 'sb/submodule-core-worktree'" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2) Jonathan Nieder
2018-09-08 2:04 ` Junio C Hamano
2018-09-08 18:39 ` Johannes Sixt
2018-09-10 17:11 ` Stefan Beller
2018-09-11 19:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907150327.GB26719@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=allan.jensen@qt.io \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).