Re: [PATCH 2/5] t/lib-submodule-update.sh: Fix test ignoring ignored files in submodules

[Stefan Beller <sbeller@google.com>]

On Fri, Dec 22, 2017 at 11:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> It turns out that this buggy test passed due to the buggy implementation,
>> which will soon be corrected.  Let's fix the test first.
>
> Please clarify "buggy test".  Without the original discussion (I am
> imagining there is something that happened on the list recently),
> here is my guess:
>
>     We tried to make sure that an ignored file is $distimmed by
>     $gostak, but forgot to tell the exclude mechanism that the path
>     'sub1'ignored' we use for the test is actually ignored, so the
>     fact that the file was not $distimmed when $gostak did its thing
>     meant nothing---mark any path whose name is 'ignored' as ignored
>     to really test the condition we want to test.
>
> but I do not exactly know what verb to replace $distim and what noun
> to replace $gostak above ;-)

Just rewrote that commit message without distims and gostaking.

> Also, wouldn't this expose a bug in the implementation if that is
> the case?

Yes it is, which will be fixed. The bug is:

If the submodule HEAD is at the superprojects recorded object
name, we don't bother looking into the submodule at all, neither for
deleting untracked files, nor resetting changed tracked files.

Thanks,

Stefan