From: Stefan Beller <sbeller@google.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jeff King <peff@peff.net>, Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH v3 3/3] submodule: extend die message on failed checkout with depth argument
Date: Mon, 11 Jan 2016 08:26:18 -0800 [thread overview]
Message-ID: <CAGZ79ka9+KxqbogbN1UnNxQ_G6U_incYKLiuadTroc90VmEWpA@mail.gmail.com> (raw)
In-Reply-To: <1450653595-22676-4-git-send-email-larsxschneider@gmail.com>
On Sun, Dec 20, 2015 at 3:19 PM, <larsxschneider@gmail.com> wrote:
> +test_expect_success 'submodule update clone shallow submodule on non-default branch' '
> + git clone cloned super4 &&
> + pwd=$(pwd) &&
> + (cd super4 &&
> + sed -e "s#url = ../#url = file://$pwd/#" <.gitmodules >.gitmodules.tmp &&
> + mv -f .gitmodules.tmp .gitmodules &&
> + test_must_fail git submodule update --init --depth=3 2>submodule.out &&
Why do we choose a depth of 3 here?
> + test_i18ngrep --count "Commit is probably not on the default branch." submodule.out
> + )
> '
>
> test_expect_success 'submodule update --recursive drops module name before recursing' '
> --
> 2.5.1
>
next prev parent reply other threads:[~2016-01-11 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 23:19 [PATCH v3 0/3] add test to demonstrate that shallow recursive clones fail larsxschneider
2015-12-20 23:19 ` [PATCH v3 1/3] submodule: " larsxschneider
2016-03-15 19:50 ` Stefan Beller
2016-03-15 20:12 ` Junio C Hamano
2016-03-20 17:05 ` Lars Schneider
2016-03-20 19:40 ` Jeff King
2016-03-20 21:27 ` Stefan Beller
2015-12-20 23:19 ` [PATCH v3 2/3] submodule: fix &&-chain breakage larsxschneider
2015-12-20 23:19 ` [PATCH v3 3/3] submodule: extend die message on failed checkout with depth argument larsxschneider
2016-01-11 16:26 ` Stefan Beller [this message]
2016-01-12 9:29 ` Lars Schneider
2016-01-12 23:32 ` Stefan Beller
2016-01-07 21:50 ` [PATCH v3 0/3] add test to demonstrate that shallow recursive clones fail Lars Schneider
2016-01-11 16:29 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79ka9+KxqbogbN1UnNxQ_G6U_incYKLiuadTroc90VmEWpA@mail.gmail.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).