From: Lars Schneider <larsxschneider@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jeff King <peff@peff.net>, Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail
Date: Sun, 20 Mar 2016 18:05:34 +0100 [thread overview]
Message-ID: <0767AEDB-36D6-45BE-A1CC-944ECAFC00FB@gmail.com> (raw)
In-Reply-To: <CAGZ79kYzbmzK1UwvWheugkqG0FwhpGMU0_K_jyCKOnoKb5oTxQ@mail.gmail.com>
On 15 Mar 2016, at 20:50, Stefan Beller <sbeller@google.com> wrote:
> On Sun, Dec 20, 2015 at 3:19 PM, <larsxschneider@gmail.com> wrote:
>> From: Lars Schneider <larsxschneider@gmail.com>
>>
>> "git clone --recursive --depth 1 --single-branch <url>" clones the
>> submodules successfully. However, it does not obey "--depth 1" for
>> submodule cloning.
>
> I am about to resend "[RFC/PATCH] clone: add `--shallow-submodules` flag"
> which would need tests and I thought about this series as tests.
Sounds good, thanks!
> I assume patch 2 (fixing a broken && chain in tests) made it through,
> but patch 1 and 3 did not? I may pick up ideas from here as it will be
> slightly different tests I'd guess.
Unfortunately patch 2 ($gmane/282776) did not made it in (I just checked
next 104e649). How should we proceed?
>
>
>> +test_expect_failure shallow-clone-recursive '
>> + URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" &&
>
> This would break if the test suite is in a path containing any other white space
> than U+0020 such as a tab? (Not that I am encouraging using such paths...)
True. I wonder if we really need to use the "file://" URL format here. Maybe
a relative would be easier?!
Thanks,
Lars
next prev parent reply other threads:[~2016-03-20 17:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 23:19 [PATCH v3 0/3] add test to demonstrate that shallow recursive clones fail larsxschneider
2015-12-20 23:19 ` [PATCH v3 1/3] submodule: " larsxschneider
2016-03-15 19:50 ` Stefan Beller
2016-03-15 20:12 ` Junio C Hamano
2016-03-20 17:05 ` Lars Schneider [this message]
2016-03-20 19:40 ` Jeff King
2016-03-20 21:27 ` Stefan Beller
2015-12-20 23:19 ` [PATCH v3 2/3] submodule: fix &&-chain breakage larsxschneider
2015-12-20 23:19 ` [PATCH v3 3/3] submodule: extend die message on failed checkout with depth argument larsxschneider
2016-01-11 16:26 ` Stefan Beller
2016-01-12 9:29 ` Lars Schneider
2016-01-12 23:32 ` Stefan Beller
2016-01-07 21:50 ` [PATCH v3 0/3] add test to demonstrate that shallow recursive clones fail Lars Schneider
2016-01-11 16:29 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0767AEDB-36D6-45BE-A1CC-944ECAFC00FB@gmail.com \
--to=larsxschneider@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).