From: Stefan Beller <sbeller@google.com>
To: Valery Tolstov <me@vtolstov.org>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] submodule--helper.c: remove duplicate code
Date: Wed, 8 Mar 2017 15:15:40 -0800 [thread overview]
Message-ID: <CAGZ79ka7PNKq5JWLPujvVHJWf6eEUadaJXd5AmKEvKT_y1ghOA@mail.gmail.com> (raw)
In-Reply-To: <20170308230512.30572-1-me@vtolstov.org>
On Wed, Mar 8, 2017 at 3:05 PM, Valery Tolstov <me@vtolstov.org> wrote:
>> Then the next step (as outlined by Documentation/SubmittingPatches)
>> is to figure out how to best present this to the mailing list; I think the best
>> way is to send out a patch series consisting of both of these 2 patches,
>> the "connect_work_tree_and_git_dir: safely create leading directories,"
>> first and then your deduplication patch.
>
> Is there a handy way to forward your patch in new patch series?
No there is not. :(
Here is what I would do:
* Take the patch and "git am" it (you probably did that for testing already.)
* use "git rebase --interactive" to get the order right,
* use "git format-patch HEAD^^ --cover-letter" to create the series.
(This will take care of e.g. rewriting the patch to be numbered correctly)
* use "git send-email 00* --to=list --cc=Junio ..." etc to send it out
as a new series.
Alternatively you can take the patch file you sent and that patch and
manually edit their numbering and send them out.
(PATCH 1/2 and PATCH 2/2)
> Also,
> should I start new thread for new patch series?
As you like.
As far as I understand, it is very easy for Junio to take a whole
(sub-)thread of patches and apply that and make a branch with
multiple commits out of it as he has tooling for that.
>
> Regards,
> Valery Tolstov
Thanks,
Stefan
next prev parent reply other threads:[~2017-03-08 23:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 17:44 [PATCH] submodule--helper.c: remove duplicate code me
2017-03-08 18:53 ` Stefan Beller
2017-03-08 19:59 ` Valery Tolstov
2017-03-08 20:25 ` Stefan Beller
2017-03-08 23:05 ` Valery Tolstov
2017-03-08 23:15 ` Stefan Beller [this message]
2017-03-08 23:24 ` Junio C Hamano
2017-03-08 23:34 ` Stefan Beller
2017-03-09 0:03 ` [PATCH v2 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09 0:03 ` [PATCH v2 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09 0:03 ` [PATCH v2 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09 0:38 ` Brandon Williams
2017-03-09 1:27 ` [PATCH v3 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09 1:27 ` [PATCH v3 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09 1:27 ` [PATCH v3 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09 18:18 ` Brandon Williams
2017-03-10 19:42 ` Junio C Hamano
2017-03-10 19:49 ` Stefan Beller
2017-03-10 20:40 ` Junio C Hamano
2017-03-10 20:48 ` Stefan Beller
2017-03-09 22:54 ` Valery Tolstov
2017-03-09 0:28 ` [PATCH v2 0/2] Remove duplicate code from module_clone() Brandon Williams
2017-03-09 0:56 ` Valery Tolstov
2017-03-09 18:19 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79ka7PNKq5JWLPujvVHJWf6eEUadaJXd5AmKEvKT_y1ghOA@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=me@vtolstov.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).