From: Stefan Beller <sbeller@google.com>
To: Brandon Williams <bmwill@google.com>
Cc: Jeff King <peff@peff.net>, Joachim Durchholz <jo@durchholz.org>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: problem with backslash in directory name
Date: Fri, 7 Apr 2017 09:55:05 -0700 [thread overview]
Message-ID: <CAGZ79ka7PEWy2iA8V9s11n2kyD=vHyS2y1K3SJzDq-5HsY7how@mail.gmail.com> (raw)
In-Reply-To: <20170407165314.GB142670@google.com>
>> Probably it's "read" which does backslash expansion, but nothing else.
>> Just grepping git-submodule.sh, some of the "read" calls should probably
>> be "read -r" (I also don't know how some of those loops would cope with
>> a submodule name that needed quoting).
>
> So I blindly converted all "read" calls to "read -r" and tested against
> the case Joachim ran into and it seems to solve the issues. All test
> still pass too (though that may not mean too much).
... because we may not have tests with weird names in submodule path.
Thanks for the conversion!
Stefan
next prev parent reply other threads:[~2017-04-07 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 6:12 problem with backslash in directory name Joachim Durchholz
2017-04-07 6:30 ` Jeff King
2017-04-07 8:24 ` Joachim Durchholz
2017-04-07 8:40 ` Joachim Durchholz
2017-04-07 16:53 ` Brandon Williams
2017-04-07 16:55 ` Stefan Beller [this message]
2017-04-07 17:23 ` [PATCH] submodule: prevent backslash expantion in submodule names Brandon Williams
2017-04-07 17:35 ` Joachim Durchholz
2017-04-08 10:59 ` Jeff King
2017-04-08 20:32 ` Joachim Durchholz
2017-04-17 3:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79ka7PEWy2iA8V9s11n2kyD=vHyS2y1K3SJzDq-5HsY7how@mail.gmail.com' \
--to=sbeller@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jo@durchholz.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).