From: Jeff King <peff@peff.net>
To: Joachim Durchholz <jo@durchholz.org>
Cc: Stefan Beller <sbeller@google.com>,
Brandon Williams <bmwill@google.com>,
git@vger.kernel.org
Subject: Re: problem with backslash in directory name
Date: Fri, 7 Apr 2017 02:30:57 -0400 [thread overview]
Message-ID: <20170407063057.yjbqavu4uiipslpc@sigill.intra.peff.net> (raw)
In-Reply-To: <9e3af7d6-a2c1-2673-53cc-d4c5105d9051@durchholz.org>
On Fri, Apr 07, 2017 at 08:12:49AM +0200, Joachim Durchholz wrote:
> So... something inside "git submodule add" is replacing the \b with a
> backspace control code.
> [...]
> Whatever that "something" is, it is not doing shell expansion, otherwise it
> would have started an interactive calculator session.
Probably it's "read" which does backslash expansion, but nothing else.
Just grepping git-submodule.sh, some of the "read" calls should probably
be "read -r" (I also don't know how some of those loops would cope with
a submodule name that needed quoting).
-Peff
next prev parent reply other threads:[~2017-04-07 6:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 6:12 problem with backslash in directory name Joachim Durchholz
2017-04-07 6:30 ` Jeff King [this message]
2017-04-07 8:24 ` Joachim Durchholz
2017-04-07 8:40 ` Joachim Durchholz
2017-04-07 16:53 ` Brandon Williams
2017-04-07 16:55 ` Stefan Beller
2017-04-07 17:23 ` [PATCH] submodule: prevent backslash expantion in submodule names Brandon Williams
2017-04-07 17:35 ` Joachim Durchholz
2017-04-08 10:59 ` Jeff King
2017-04-08 20:32 ` Joachim Durchholz
2017-04-17 3:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407063057.yjbqavu4uiipslpc@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jo@durchholz.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).