From: Stefan Beller <sbeller@google.com>
To: Andrey Okoshkin <a.okoshkin@samsung.com>
Cc: "Eric Sunshine" <sunshine@sunshineco.com>,
"Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
vmiklos@frugalware.org
Subject: Re: [PATCH v3] merge-recursive: check GIT_MERGE_VERBOSITY only once
Date: Fri, 27 Oct 2017 10:29:01 -0700 [thread overview]
Message-ID: <CAGZ79kZ9EV=qaYyuA3kfuQ04EhLWax52MhtkmGJto2Lommc_SQ@mail.gmail.com> (raw)
In-Reply-To: <bd7eb593-75f9-0dd1-9dff-9dc420532217@samsung.com>
On Wed, Oct 25, 2017 at 6:03 AM, Andrey Okoshkin <a.okoshkin@samsung.com> wrote:
> Get 'GIT_MERGE_VERBOSITY' environment variable only once in
> init_merge_options() and store the pointer to its value for the further check.
> No intervening calls to getenv(), putenv(), setenv() or unsetenv() are done
> between the initial getenv() call and the consequential result pass to strtol()
> as these environment related functions could modify the string pointer returned
> by the initial getenv() call.
>
> Signed-off-by: Andrey Okoshkin <a.okoshkin@samsung.com>
This is
Reviewed-by: Stefan Beller <sbeller@google.com>
next prev parent reply other threads:[~2017-10-27 17:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171024152727epcas2p4fb7dcf147e44aadf7733098151d469a5@epcas2p4.samsung.com>
2017-10-24 15:27 ` [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once Andrey Okoshkin
2017-10-24 16:28 ` Stefan Beller
2017-10-24 16:45 ` Eric Sunshine
2017-10-24 17:11 ` Martin Ågren
2017-10-24 19:52 ` Jeff King
2017-10-25 1:48 ` Junio C Hamano
2017-10-25 4:07 ` Eric Sunshine
2017-10-25 7:27 ` Jeff King
2017-10-25 11:39 ` [PATCH v2] " Andrey Okoshkin
2017-10-25 11:53 ` Eric Sunshine
2017-10-25 12:27 ` Andrey Okoshkin
2017-10-25 13:03 ` [PATCH v3] " Andrey Okoshkin
2017-10-27 17:29 ` Stefan Beller [this message]
2017-10-30 7:42 ` [PATCH v4] " Andrey Okoshkin
2017-10-31 1:42 ` Junio C Hamano
2017-10-31 2:26 ` Junio C Hamano
2017-10-31 7:13 ` Andrey Okoshkin
2017-10-31 7:20 ` Junio C Hamano
2017-10-31 9:09 ` [PATCH v5] " Andrey Okoshkin
2017-10-25 11:13 ` [PATCH] " Andrey Okoshkin
2017-10-25 10:49 ` Andrey Okoshkin
2017-10-25 10:49 ` Andrey Okoshkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kZ9EV=qaYyuA3kfuQ04EhLWax52MhtkmGJto2Lommc_SQ@mail.gmail.com' \
--to=sbeller@google.com \
--cc=a.okoshkin@samsung.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).