git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Orgad Shaneh <orgads@gmail.com>
To: Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v2] submodule: suppress checking for file name ambiguity for object ids
Date: Sun, 6 Sep 2020 22:25:28 +0300	[thread overview]
Message-ID: <CAGHpTBKduYnWymtCYR0AAdYy4rhXZgQkrUiHu59bpNX5UDEYfg@mail.gmail.com> (raw)
In-Reply-To: <pull.725.v2.git.1599370473141.gitgitgadget@gmail.com>

On Sun, Sep 6, 2020 at 8:34 AM Orgad Shaneh via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Orgad Shaneh <orgads@gmail.com>
>
> The argv argument of collect_changed_submodules() contains obly object ids
> (the objects references of all the refs).
>
> Notify setup_revisions() that the input is not filenames by passing
> assume_dashdash, so it can avoid redundant stat for each ref.
>
> A better improvement would be to pass oid_array instead of stringified argv,
> but that will require a larger change, which can be done later.

I'm wondering if it would be possible to track all the commits that
were received
via the transport, instead of resolving them by ref changes, because resolving
from refs requires excluding all the previously-known refs, which can be a lot.
Our repository has ~35K tags, and I believe there are larger repos out there...

What do you say?

- Orgad

  reply	other threads:[~2020-09-06 19:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 14:53 [PATCH] " Orgad Shaneh via GitGitGadget
2020-09-06  5:34 ` [PATCH v2] " Orgad Shaneh via GitGitGadget
2020-09-06 19:25   ` Orgad Shaneh [this message]
2020-09-06 20:47   ` [PATCH v3] submodule: suppress checking for file name and ref " Orgad Shaneh via GitGitGadget
2020-09-06 20:53     ` [PATCH v4] " Orgad Shaneh via GitGitGadget
2020-09-06 20:59       ` Ramsay Jones
2020-09-06 21:59   ` [PATCH v2] submodule: suppress checking for file name " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGHpTBKduYnWymtCYR0AAdYy4rhXZgQkrUiHu59bpNX5UDEYfg@mail.gmail.com \
    --to=orgads@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --subject='Re: [PATCH v2] submodule: suppress checking for file name ambiguity for object ids' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).