From: "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Orgad Shaneh <orgads@gmail.com>, Orgad Shaneh <orgads@gmail.com>
Subject: [PATCH v2] submodule: suppress checking for file name ambiguity for object ids
Date: Sun, 06 Sep 2020 05:34:32 +0000 [thread overview]
Message-ID: <pull.725.v2.git.1599370473141.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.725.git.1599231196975.gitgitgadget@gmail.com>
From: Orgad Shaneh <orgads@gmail.com>
The argv argument of collect_changed_submodules() contains obly object ids
(the objects references of all the refs).
Notify setup_revisions() that the input is not filenames by passing
assume_dashdash, so it can avoid redundant stat for each ref.
A better improvement would be to pass oid_array instead of stringified argv,
but that will require a larger change, which can be done later.
Signed-off-by: Orgad Shaneh <orgads@gmail.com>
---
submodule: suppress checking for file name ambiguity for object ids
The argv argument of collect_changed_submodules() contains obly object
ids (submodule references).
Notify setup_revisions() that the input is not filenames by passing
assume_dashdash, so it can avoid redundant stat for each ref.
A better improvement would be to pass oid_array instead of stringified
argv, but that will require a larger change, which can be done later.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-725%2Forgads%2Fsubmodule-not-filename-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-725/orgads/submodule-not-filename-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/725
Range-diff vs v1:
1: f12112cc88 ! 1: 501ce90e9a submodule: suppress checking for file name ambiguity for object ids
@@ Commit message
submodule: suppress checking for file name ambiguity for object ids
The argv argument of collect_changed_submodules() contains obly object ids
- (submodule references).
+ (the objects references of all the refs).
Notify setup_revisions() that the input is not filenames by passing
assume_dashdash, so it can avoid redundant stat for each ref.
submodule.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index 3cbcf40dfc..9b5bfb12a3 100644
--- a/submodule.c
+++ b/submodule.c
@@ -840,9 +840,12 @@ static void collect_changed_submodules(struct repository *r,
{
struct rev_info rev;
const struct commit *commit;
+ struct setup_revision_opt s_r_opt = {
+ .assume_dashdash = 1,
+ };
repo_init_revisions(r, &rev, NULL);
- setup_revisions(argv->nr, argv->v, &rev, NULL);
+ setup_revisions(argv->nr, argv->v, &rev, &s_r_opt);
if (prepare_revision_walk(&rev))
die(_("revision walk setup failed"));
base-commit: 3a238e539bcdfe3f9eb5010fd218640c1b499f7a
--
gitgitgadget
next prev parent reply other threads:[~2020-09-06 5:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 14:53 [PATCH] submodule: suppress checking for file name ambiguity for object ids Orgad Shaneh via GitGitGadget
2020-09-06 5:34 ` Orgad Shaneh via GitGitGadget [this message]
2020-09-06 19:25 ` [PATCH v2] " Orgad Shaneh
2020-09-06 20:47 ` [PATCH v3] submodule: suppress checking for file name and ref " Orgad Shaneh via GitGitGadget
2020-09-06 20:53 ` [PATCH v4] " Orgad Shaneh via GitGitGadget
2020-09-06 20:59 ` Ramsay Jones
2020-09-06 21:59 ` [PATCH v2] submodule: suppress checking for file name " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.725.v2.git.1599370473141.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).