From: Orgad Shaneh <orgads@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Rebase: Run post-checkout hook on checkout
Date: Sat, 29 Dec 2018 23:31:28 +0200 [thread overview]
Message-ID: <CAGHpTBK+1JxhqGDNsjY4Qevd65gSYYeVMBVpHxa0=0OrKbbrEg@mail.gmail.com> (raw)
In-Reply-To: <xmqqimzdl0v4.fsf@gitster-ct.c.googlers.com>
On Sat, Dec 29, 2018 at 12:53 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> orgads@gmail.com writes:
>
> > From: Orgad Shaneh <orgads@gmail.com>
>
> > Re: [PATCH 2/2] Rebase: Run post-checkout hook on checkout
>
> There is no explanation here?
>
> Is this a regression fix (i.e. scripted version of "rebase" used to
> run the hook)? Or a new feature (i.e. no earlier version of
> "rebase" run the hook but you think it ought to run it)?
Added an explanation.
[snip]
>
> > +#define RESET_HEAD_RUN_HOOK (1<<2)
>
> Would it be plausible that the only possible hook that can be run by
> reset_head() function will always be post-checkout and nothing else,
> I wonder? Shouldn't this bit be called *_RUN_POST_CHECKOUT to make
> sure it is specific enough?
Done
[snip]
>
> > +test_expect_success 'post-checkout is triggered on rebase' '
> > + git checkout -b rebase-test master &&
> > + rm -f .git/post-checkout.args &&
>
> Read the title of this whole test script file; it should verify what
> is in the file before removing it.
Why? Other tests already do it. This test is meant for rebase, not
plain checkout.
>
> > + git rebase rebase-on-me &&
> > + read old new flag < .git/post-checkout.args &&
>
> No SP between "<" and ".git/post-checkout.args".
Done
> > + test $old != $new && test $flag = 1 &&
> > + rm -f .git/post-checkout.args
> > +'
>
> Regarding the clean-up of this file, see my review on the previous
> one.
Done
> > +test_expect_success 'post-checkout is triggered on rebase with fast-forward' '
>
> The same comment as above applies to this.
Done
Thanks,
- Orgad
next prev parent reply other threads:[~2018-12-29 21:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 21:24 [PATCH] Rebase: Run post-checkout hook on checkout orgads
2018-12-24 21:24 ` [PATCH 1/2] t5403: Refactor orgads
2018-12-28 22:34 ` Junio C Hamano
2018-12-29 3:06 ` Ramsay Jones
2018-12-29 21:36 ` Orgad Shaneh
2018-12-24 21:24 ` [PATCH 2/2] Rebase: Run post-checkout hook on checkout orgads
2018-12-28 22:53 ` Junio C Hamano
2018-12-29 21:31 ` Orgad Shaneh [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-29 21:37 [PATCH 1/2] t5403: simplify by using a single repository orgads
2018-12-29 21:37 ` [PATCH 2/2] Rebase: Run post-checkout hook on checkout orgads
2019-01-02 15:47 ` Johannes Schindelin
2018-12-20 21:55 [PATCH 1/2] t5403: Refactor orgads
2018-12-20 21:55 ` [PATCH 2/2] Rebase: Run post-checkout hook on checkout orgads
2018-12-20 21:48 [PATCH 1/2] t5403: Refactor orgads
2018-12-20 21:48 ` [PATCH 2/2] Rebase: Run post-checkout hook on checkout orgads
2018-12-21 16:12 ` Johannes Schindelin
2018-12-24 21:24 ` Orgad Shaneh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGHpTBK+1JxhqGDNsjY4Qevd65gSYYeVMBVpHxa0=0OrKbbrEg@mail.gmail.com' \
--to=orgads@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).