[PATCH] Document the 'svn propset' command.

[PATCH] Document the 'svn propset' command.

[Alfred Perlstein]

Junio + all,

A week ago I was requested to provide documentation for the
'svn propset' command.  I have attached a diff off of the
'maint' branch for this, however it seems to apply cleanly
to 'master' as well.

Thank you for your patience.

This is also available on my github here:
https://github.com/splbio/git/tree/document_propset


---
 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index fb23a98..e104824 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
 	Gets the Subversion property given as the first argument, for a
 	file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+	Sets the Subversion property given as the first argument, to the
+	value given as the second argument for the file given as the
+	third argument.
++
+Example:
++
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
 'show-externals'::
 	Shows the Subversion externals.  Use -r/--revision to specify a
 	specific revision.
-- 
2.7.1

Re: [PATCH] Document the 'svn propset' command.

[Pranit Bauva]

Hey Alfred,

On Mon, Jun 13, 2016 at 12:45 AM, Alfred Perlstein <alfred@freebsd.org> wrote:
> Junio + all,
>
> A week ago I was requested to provide documentation for the
> 'svn propset' command.  I have attached a diff off of the
> 'maint' branch for this, however it seems to apply cleanly
> to 'master' as well.
>
> Thank you for your patience.
>
> This is also available on my github here:
> https://github.com/splbio/git/tree/document_propset

I am not particularly sure whether the above could form a good commit
message. I think you wanted to include this as a comment. git-am picks
up these patches. The title commit is taken from the subject stripping
the '[PATCH]'. Then the body before '---' is taken as the rest of the
commit message. Then the diff is applied. To include comments add them
after ---. Also please have a look at Documentation/SubmittingPatches.
Also missing signoff. For the patch to actually be accept you need to
follow those instructions. Thanks for contributing.

> ---
>  Documentation/git-svn.txt | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
> index fb23a98..e104824 100644
> --- a/Documentation/git-svn.txt
> +++ b/Documentation/git-svn.txt
> @@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
>         Gets the Subversion property given as the first argument, for a
>         file.  A specific revision can be specified with -r/--revision.
>
> +'propset'::
> +       Sets the Subversion property given as the first argument, to the
> +       value given as the second argument for the file given as the
> +       third argument.
> ++
> +Example:
> ++
> +------------------------------------------------------------------------
> +git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
> +------------------------------------------------------------------------
> ++
> +This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
> +'devel/py-tipper/Makefile'.
> +
>  'show-externals'::
>         Shows the Subversion externals.  Use -r/--revision to specify a
>         specific revision.

Regards,
Pranit Bauva

Re: [PATCH] Document the 'svn propset' command.

[Alfred Perlstein]

Thank you Pranit.  I thought that "signed off by" is used once someone 
approved my patch as opposed to when it's in "proposal" stage.  This was 
my first email with a patch for this issue, who should/could I have used 
for "signoff"?


-Alfred


On 6/12/16 11:59 PM, Pranit Bauva wrote:
> Hey Alfred,
>
> On Mon, Jun 13, 2016 at 12:45 AM, Alfred Perlstein <alfred@freebsd.org> wrote:
>> Junio + all,
>>
>> A week ago I was requested to provide documentation for the
>> 'svn propset' command.  I have attached a diff off of the
>> 'maint' branch for this, however it seems to apply cleanly
>> to 'master' as well.
>>
>> Thank you for your patience.
>>
>> This is also available on my github here:
>> https://github.com/splbio/git/tree/document_propset
> I am not particularly sure whether the above could form a good commit
> message. I think you wanted to include this as a comment. git-am picks
> up these patches. The title commit is taken from the subject stripping
> the '[PATCH]'. Then the body before '---' is taken as the rest of the
> commit message. Then the diff is applied. To include comments add them
> after ---. Also please have a look at Documentation/SubmittingPatches.
> Also missing signoff. For the patch to actually be accept you need to
> follow those instructions. Thanks for contributing.
>
>> ---
>>   Documentation/git-svn.txt | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
>> index fb23a98..e104824 100644
>> --- a/Documentation/git-svn.txt
>> +++ b/Documentation/git-svn.txt
>> @@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
>>          Gets the Subversion property given as the first argument, for a
>>          file.  A specific revision can be specified with -r/--revision.
>>
>> +'propset'::
>> +       Sets the Subversion property given as the first argument, to the
>> +       value given as the second argument for the file given as the
>> +       third argument.
>> ++
>> +Example:
>> ++
>> +------------------------------------------------------------------------
>> +git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
>> +------------------------------------------------------------------------
>> ++
>> +This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
>> +'devel/py-tipper/Makefile'.
>> +
>>   'show-externals'::
>>          Shows the Subversion externals.  Use -r/--revision to specify a
>>          specific revision.
> Regards,
> Pranit Bauva
>

Re: [PATCH] Document the 'svn propset' command.

[Pranit Bauva]

Hey Alfred,

On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
> Thank you Pranit.  I thought that "signed off by" is used once someone
> approved my patch as opposed to when it's in "proposal" stage.  This was my
> first email with a patch for this issue, who should/could I have used for
> "signoff"?

Signoff is used to indicate that you are OKAY with releasing your
patch according to git's license. For more details see the
Documentation/SubmittingPatches[1]. To summarize you will have to add
this in the end :

   Signed-off-by: Alfred Perlstein <alfred@freebsd.org>

Though I will still recommend you to go through [1] properly.

Regards,
Pranit Bauva

Re: [PATCH] Document the 'svn propset' command.

[Pranit Bauva]

Hey Alfred,

On Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
> Hey Alfred,
>
> On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
>> Thank you Pranit.  I thought that "signed off by" is used once someone
>> approved my patch as opposed to when it's in "proposal" stage.  This was my
>> first email with a patch for this issue, who should/could I have used for
>> "signoff"?
>
> Signoff is used to indicate that you are OKAY with releasing your
> patch according to git's license. For more details see the
> Documentation/SubmittingPatches[1]. To summarize you will have to add
> this in the end :
>
>    Signed-off-by: Alfred Perlstein <alfred@freebsd.org>
>
> Though I will still recommend you to go through [1] properly.

Oops I forgot to put the link.

[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307

Regards,
Pranit Bauva

Re: [PATCH] Document the 'svn propset' command.

[Alfred Perlstein]

On 6/13/16 7:42 AM, Pranit Bauva wrote:
> Hey Alfred,
>
> On Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> Hey Alfred,
>>
>> On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
>>> Thank you Pranit.  I thought that "signed off by" is used once someone
>>> approved my patch as opposed to when it's in "proposal" stage.  This was my
>>> first email with a patch for this issue, who should/could I have used for
>>> "signoff"?
>> Signoff is used to indicate that you are OKAY with releasing your
>> patch according to git's license. For more details see the
>> Documentation/SubmittingPatches[1]. To summarize you will have to add
>> this in the end :
>>
>>     Signed-off-by: Alfred Perlstein <alfred@freebsd.org>
>>
>> Though I will still recommend you to go through [1] properly.
> Oops I forgot to put the link.
>
> [1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307
>
Pranit,

Ah thank you!!!  This clarifies.  I will resend the patch tonight.

-Alfred

[PATCH] Document the 'svn propset' command.

[Alfred Perlstein]

Add example usage to the git-svn documentation.

Reported-by: Joseph Pecoraro <pecoraro@apple.com>
Signed-off-by: Alfred Perlstein <alfred@freebsd.org> 
---

Junio, Pranit, + all,

A week ago I was requested to provide documentation for the
'svn propset' command.  I have attached a diff off of the
'maint' branch for this, however it seems to apply cleanly
to 'master' as well.

Thank you for your patience.

This is also available on my github here:
https://github.com/splbio/git/tree/document_propset



 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index fb23a98..e104824 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
 	Gets the Subversion property given as the first argument, for a
 	file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+	Sets the Subversion property given as the first argument, to the
+	value given as the second argument for the file given as the
+	third argument.
++
+Example:
++
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
 'show-externals'::
 	Shows the Subversion externals.  Use -r/--revision to specify a
 	specific revision.
-- 
2.7.1

Re: [PATCH] Document the 'svn propset' command.

[Eric Wong]

Alfred Perlstein <alfred@freebsd.org> wrote:
> Add example usage to the git-svn documentation.
> 
> Reported-by: Joseph Pecoraro <pecoraro@apple.com>
> Signed-off-by: Alfred Perlstein <alfred@freebsd.org> 
> ---
> 
> Junio, Pranit, + all,
> 
> A week ago I was requested to provide documentation for the
> 'svn propset' command.  I have attached a diff off of the
> 'maint' branch for this, however it seems to apply cleanly
> to 'master' as well.
> 
> Thank you for your patience.

Thanks Alfred,

I've removed the '.' from the commit subject, signed-off,
and pushed to my repo for Junio:

The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:

  Git 2.9 (2016-06-13 10:42:13 -0700)

are available in the git repository at:

  git://bogomips.org/git-svn.git svn-propset-doc

for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:

  Document the 'svn propset' command (2016-06-15 20:11:22 +0000)

----------------------------------------------------------------
Alfred Perlstein (1):
      Document the 'svn propset' command

 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Re: [PATCH] Document the 'svn propset' command.

[Junio C Hamano]

Eric Wong <e@80x24.org> writes:

> Thanks Alfred,
>
> I've removed the '.' from the commit subject, signed-off,
> and pushed to my repo for Junio:
>
> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:
>
>   Git 2.9 (2016-06-13 10:42:13 -0700)
>
> are available in the git repository at:
>
>   git://bogomips.org/git-svn.git svn-propset-doc
>
> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:
>
>   Document the 'svn propset' command (2016-06-15 20:11:22 +0000)

I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
support for git-svn propset, 2014-12-07) so that it could go to
older maintenance tracks.

I will pick up your Reviewed-by: and redo it.  Thanks.

Re: [PATCH] Document the 'svn propset' command.

[Alfred Perlstein]

> On Jun 15, 2016, at 1:21 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Eric Wong <e@80x24.org> writes:
> 
>> Thanks Alfred,
>> 
>> I've removed the '.' from the commit subject, signed-off,
>> and pushed to my repo for Junio:
>> 
>> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:
>> 
>>  Git 2.9 (2016-06-13 10:42:13 -0700)
>> 
>> are available in the git repository at:
>> 
>>  git://bogomips.org/git-svn.git svn-propset-doc
>> 
>> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:
>> 
>>  Document the 'svn propset' command (2016-06-15 20:11:22 +0000)
> 
> I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
> support for git-svn propset, 2014-12-07) so that it could go to
> older maintenance tracks.
> 
> I will pick up your Reviewed-by: and redo it.  Thanks.
> 

Thank you, always great working with the git project!  

-Alfred 

Re: [PATCH] Document the 'svn propset' command.

[Joseph Pecoraro]

> On Jun 15, 2016, at 1:24 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
> 
>> On Jun 15, 2016, at 1:21 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Eric Wong <e@80x24.org> writes:
>> 
>>> Thanks Alfred,
>>> 
>>> I've removed the '.' from the commit subject, signed-off,
>>> and pushed to my repo for Junio:
>>> 
>>> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:
>>> 
>>> Git 2.9 (2016-06-13 10:42:13 -0700)
>>> 
>>> are available in the git repository at:
>>> 
>>> git://bogomips.org/git-svn.git svn-propset-doc
>>> 
>>> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:
>>> 
>>> Document the 'svn propset' command (2016-06-15 20:11:22 +0000)
>> 
>> I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
>> support for git-svn propset, 2014-12-07) so that it could go to
>> older maintenance tracks.
>> 
>> I will pick up your Reviewed-by: and redo it.  Thanks.
>> 
> 
> Thank you, always great working with the git project!  
> 
> -Alfred 

Thanks for addressing this!

- Joe