From: Han-Wen Nienhuys <hanwen@google.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t"
Date: Tue, 11 Jan 2022 20:31:47 +0100 [thread overview]
Message-ID: <CAFQ2z_M0Fjjx8tAd_cXqk9K9q43hwienEy=UsLJi2aW8G3sEwA@mail.gmail.com> (raw)
In-Reply-To: <Yd3aZ5Q9Ph0H+Ijn@nand.local>
On Tue, Jan 11, 2022 at 8:28 PM Taylor Blau <me@ttaylorr.com> wrote:
>
> On Tue, Jan 11, 2022 at 05:40:23PM +0100, Ævar Arnfjörð Bjarmason wrote:
> > diff --git a/reftable/merged_test.c b/reftable/merged_test.c
> > index 24461e8a802..b87ff495dfd 100644
> > --- a/reftable/merged_test.c
> > +++ b/reftable/merged_test.c
> > @@ -24,8 +24,8 @@ license that can be found in the LICENSE file or at
> > static void write_test_table(struct strbuf *buf,
> > struct reftable_ref_record refs[], int n)
> > {
> > - int min = 0xffffffff;
> > - int max = 0;
> > + uint64_t min = 0xffffffff;
> > + uint64_t max = 0;
>
> Han-Wen: it looks like the loop below the context here is to set the
> min/max of update_index over all of the ref records?
correct.
> But perhaps not so from a width perspective, if sizeof(int) != 8 (though
> I suspect in practice that we are unlikely to have enough possible
> values of update_index for that to matter).
correct.
> In any case, you're only setting the lower half of `min` high. Maybe:
>
> uint64_t min = ~0ul;
yeah, that works.
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
next prev parent reply other threads:[~2022-01-11 19:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 16:40 [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Ævar Arnfjörð Bjarmason
2022-01-11 16:40 ` [PATCH 1/3] test-tool genzeros: initialize "zeros" to avoid SunCC warning Ævar Arnfjörð Bjarmason
2022-01-11 19:06 ` Taylor Blau
2022-01-12 14:21 ` Johannes Schindelin
2022-01-12 19:10 ` Taylor Blau
2022-01-13 10:08 ` Ævar Arnfjörð Bjarmason
2022-01-13 15:31 ` Johannes Schindelin
2022-01-13 17:38 ` Junio C Hamano
2022-01-11 16:40 ` [PATCH 2/3] reftable: remove unreachable "return" statements Ævar Arnfjörð Bjarmason
2022-01-11 19:16 ` Taylor Blau
2022-01-12 12:47 ` Ævar Arnfjörð Bjarmason
2022-01-12 19:19 ` Taylor Blau
2022-01-13 10:29 ` Ævar Arnfjörð Bjarmason
2022-01-13 15:39 ` Johannes Schindelin
2022-01-13 20:17 ` Johannes Sixt
2022-01-13 21:37 ` Junio C Hamano
2022-01-11 16:40 ` [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t" Ævar Arnfjörð Bjarmason
2022-01-11 19:28 ` Taylor Blau
2022-01-11 19:31 ` Han-Wen Nienhuys [this message]
2022-01-11 19:41 ` Taylor Blau
2022-01-11 20:08 ` Johannes Sixt
2022-01-11 20:18 ` Taylor Blau
2022-01-11 20:21 ` Johannes Sixt
2022-01-11 20:24 ` Taylor Blau
2022-01-12 14:18 ` Johannes Schindelin
2022-01-12 19:02 ` Junio C Hamano
2022-01-12 19:07 ` Taylor Blau
2022-01-13 10:04 ` Ævar Arnfjörð Bjarmason
2022-01-13 21:38 ` Junio C Hamano
2022-01-11 17:06 ` [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Han-Wen Nienhuys
2022-01-11 18:36 ` René Scharfe
2022-01-12 1:22 ` Emily Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFQ2z_M0Fjjx8tAd_cXqk9K9q43hwienEy=UsLJi2aW8G3sEwA@mail.gmail.com' \
--to=hanwen@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).