From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Han-Wen Nienhuys" <hanwen@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH 1/3] test-tool genzeros: initialize "zeros" to avoid SunCC warning
Date: Tue, 11 Jan 2022 17:40:21 +0100 [thread overview]
Message-ID: <patch-1.3-4dadf7320ab-20220111T163908Z-avarab@gmail.com> (raw)
In-Reply-To: <cover-0.3-00000000000-20220111T163908Z-avarab@gmail.com>
It isn't important for optimization to have this be "static", so let's
just initialize it and avoid this warning on Sun Studio 12.5:
"t/helper/test-genzeros.c", line 7: warning: const object should have initializer: zeros
This amends code added in df7000cd910 (test-tool genzeros: generate
large amounts of data more efficiently, 2021-11-02), and first tagged
with v2.35.0-rc0.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
t/helper/test-genzeros.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/t/helper/test-genzeros.c b/t/helper/test-genzeros.c
index 8ca988d6216..5dc89eda0cb 100644
--- a/t/helper/test-genzeros.c
+++ b/t/helper/test-genzeros.c
@@ -3,8 +3,7 @@
int cmd__genzeros(int argc, const char **argv)
{
- /* static, so that it is NUL-initialized */
- static const char zeros[256 * 1024];
+ const char zeros[256 * 1024] = { 0 };
intmax_t count;
ssize_t n;
--
2.35.0.rc0.844.gb5945183dcf
next prev parent reply other threads:[~2022-01-11 16:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 16:40 [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Ævar Arnfjörð Bjarmason
2022-01-11 16:40 ` Ævar Arnfjörð Bjarmason [this message]
2022-01-11 19:06 ` [PATCH 1/3] test-tool genzeros: initialize "zeros" to avoid SunCC warning Taylor Blau
2022-01-12 14:21 ` Johannes Schindelin
2022-01-12 19:10 ` Taylor Blau
2022-01-13 10:08 ` Ævar Arnfjörð Bjarmason
2022-01-13 15:31 ` Johannes Schindelin
2022-01-13 17:38 ` Junio C Hamano
2022-01-11 16:40 ` [PATCH 2/3] reftable: remove unreachable "return" statements Ævar Arnfjörð Bjarmason
2022-01-11 19:16 ` Taylor Blau
2022-01-12 12:47 ` Ævar Arnfjörð Bjarmason
2022-01-12 19:19 ` Taylor Blau
2022-01-13 10:29 ` Ævar Arnfjörð Bjarmason
2022-01-13 15:39 ` Johannes Schindelin
2022-01-13 20:17 ` Johannes Sixt
2022-01-13 21:37 ` Junio C Hamano
2022-01-11 16:40 ` [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t" Ævar Arnfjörð Bjarmason
2022-01-11 19:28 ` Taylor Blau
2022-01-11 19:31 ` Han-Wen Nienhuys
2022-01-11 19:41 ` Taylor Blau
2022-01-11 20:08 ` Johannes Sixt
2022-01-11 20:18 ` Taylor Blau
2022-01-11 20:21 ` Johannes Sixt
2022-01-11 20:24 ` Taylor Blau
2022-01-12 14:18 ` Johannes Schindelin
2022-01-12 19:02 ` Junio C Hamano
2022-01-12 19:07 ` Taylor Blau
2022-01-13 10:04 ` Ævar Arnfjörð Bjarmason
2022-01-13 21:38 ` Junio C Hamano
2022-01-11 17:06 ` [PATCH 0/3] Fix SunCC compiler complaints new in v2.35.0-rc0 Han-Wen Nienhuys
2022-01-11 18:36 ` René Scharfe
2022-01-12 1:22 ` Emily Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=patch-1.3-4dadf7320ab-20220111T163908Z-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).