git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Git Mailing List <git@vger.kernel.org>,
	Peter Krefting <peter@softwolves.pp.se>,
	Stefano Lattarini <stefano.lattarini@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Add missing test file for UTF-16.
Date: Sun, 4 Aug 2013 09:31:01 +0700	[thread overview]
Message-ID: <CACsJy8CT3uxp99n9VUXDbL30WEDcuRreeJBaqBcx9Ujici67VA@mail.gmail.com> (raw)
In-Reply-To: <1375550791-5823-1-git-send-email-sandals@crustytoothpaste.net>

On Sun, Aug 4, 2013 at 12:26 AM, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> The test file that the UTF-16 rejection test looks for is missing, but this went
> unnoticed because the test is expected to fail anyway; as a consequence, the
> test fails because the file containing the commit message is missing, and not
> because the test file contains a NUL byte.  Fix this by including a sample text
> file containing a commit message encoded in UTF-16.

Tested-by: Duy Nguyen <pclouds@gmai.com>

and sorry, my bad. I think we need your sign-off in this patch.

> ---
>  t/t3900/UTF-16.txt | Bin 0 -> 146 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 t/t3900/UTF-16.txt
>
> diff --git a/t/t3900/UTF-16.txt b/t/t3900/UTF-16.txt
> new file mode 100644
> index 0000000000000000000000000000000000000000..2257f05a992a4b9500f6ff33752cbdf8fb58c99d
> GIT binary patch
> literal 146
> zcmW-aJqm<C6obFoQ_KYvZ0uz~uwFfY_=AGZf}@2;@>bjKEzFY?FCi}po-doQaNvlX
> zuj<&j$Vh~SS#Fd&>8^}o3xQtzWRNy5zCGpzu|P`62Tv_HZgu?B*(r7K7qg7DI9e@K
> J`p+qB@d1eo8QA~;
>
> literal 0
> HcmV?d00001
>
> --
> 1.8.4.rc1
>
-- 
Duy

  reply	other threads:[~2013-08-04  2:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03 17:26 [PATCH] Add missing test file for UTF-16 brian m. carlson
2013-08-04  2:31 ` Duy Nguyen [this message]
2013-08-04 16:06   ` brian m. carlson
2013-08-05 16:44   ` Junio C Hamano
2013-08-06 11:59     ` Duy Nguyen
2013-08-06 17:24       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACsJy8CT3uxp99n9VUXDbL30WEDcuRreeJBaqBcx9Ujici67VA@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peter@softwolves.pp.se \
    --cc=sandals@crustytoothpaste.net \
    --cc=stefano.lattarini@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).