From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Git Mailing List <git@vger.kernel.org>,
Peter Krefting <peter@softwolves.pp.se>,
Stefano Lattarini <stefano.lattarini@gmail.com>
Subject: Re: [PATCH] Add missing test file for UTF-16.
Date: Tue, 6 Aug 2013 18:59:10 +0700 [thread overview]
Message-ID: <CACsJy8ACqB5qRLFCerACEQrK8QXH+n=tAxdutAGT6JeijDvJUQ@mail.gmail.com> (raw)
In-Reply-To: <7vtxj4kry1.fsf@alter.siamese.dyndns.org>
On Mon, Aug 5, 2013 at 11:44 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> On Sun, Aug 4, 2013 at 12:26 AM, brian m. carlson
>> <sandals@crustytoothpaste.net> wrote:
>>> The test file that the UTF-16 rejection test looks for is missing, but this went
>>> unnoticed because the test is expected to fail anyway; as a consequence, the
>>> test fails because the file containing the commit message is missing, and not
>>> because the test file contains a NUL byte. Fix this by including a sample text
>>> file containing a commit message encoded in UTF-16.
>>
>> Tested-by: Duy Nguyen <pclouds@gmai.com>
>>
>> and sorry, my bad. I think we need your sign-off in this patch.
>
> I think 37576c14 (commit_tree(): refuse commit messages that contain
> NULs, 2011-12-15) that marked this test with "test_expect_failure" is
> broken with or without this fix. It should be more like so:
>
> diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh
> index 37ddabb..5e72d72 100755
> --- a/t/t3900-i18n-commit.sh
> +++ b/t/t3900-i18n-commit.sh
> @@ -34,9 +34,9 @@ test_expect_success 'no encoding header for base case' '
> test z = "z$E"
> '
>
> -test_expect_failure 'UTF-16 refused because of NULs' '
> +test_expect_success 'UTF-16 refused because of NULs' '
> echo UTF-16 >F &&
> - git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt
> + test_must_fail git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt
> '
The intention was "UTF-16 is not supported yet but we want to". But I
don't think we (at least I) will put any effort on that front to allow
NUL in commit message, so the patch, as in "we do not support UTF-16",
is fine.
--
Duy
next prev parent reply other threads:[~2013-08-06 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 17:26 [PATCH] Add missing test file for UTF-16 brian m. carlson
2013-08-04 2:31 ` Duy Nguyen
2013-08-04 16:06 ` brian m. carlson
2013-08-05 16:44 ` Junio C Hamano
2013-08-06 11:59 ` Duy Nguyen [this message]
2013-08-06 17:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8ACqB5qRLFCerACEQrK8QXH+n=tAxdutAGT6JeijDvJUQ@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peter@softwolves.pp.se \
--cc=sandals@crustytoothpaste.net \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).