* [PATCH] Specify -Wformat along with -Wformat-security
@ 2018-12-27 6:58 Masaya Suzuki
2018-12-27 18:35 ` Duy Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Masaya Suzuki @ 2018-12-27 6:58 UTC (permalink / raw)
To: git; +Cc: Masaya Suzuki
Without -Wformat, -Wformat-security won't work.
> cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
---
config.mak.dev | 1 +
1 file changed, 1 insertion(+)
diff --git a/config.mak.dev b/config.mak.dev
index bbeeff44f..aae9db67d 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -7,6 +7,7 @@ CFLAGS += -pedantic
CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
endif
CFLAGS += -Wdeclaration-after-statement
+CFLAGS += -Wformat
CFLAGS += -Wformat-security
CFLAGS += -Wno-format-zero-length
CFLAGS += -Wold-style-definition
--
2.20.1.415.g653613c723-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Specify -Wformat along with -Wformat-security
2018-12-27 6:58 [PATCH] Specify -Wformat along with -Wformat-security Masaya Suzuki
@ 2018-12-27 18:35 ` Duy Nguyen
2018-12-27 18:46 ` Masaya Suzuki
0 siblings, 1 reply; 3+ messages in thread
From: Duy Nguyen @ 2018-12-27 18:35 UTC (permalink / raw)
To: Masaya Suzuki; +Cc: Git Mailing List
On Thu, Dec 27, 2018 at 7:18 PM Masaya Suzuki <masayasuzuki@google.com> wrote:
>
> Without -Wformat, -Wformat-security won't work.
>
> > cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
Compiler name and version?
>
> Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
> ---
> config.mak.dev | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.dev b/config.mak.dev
> index bbeeff44f..aae9db67d 100644
> --- a/config.mak.dev
> +++ b/config.mak.dev
> @@ -7,6 +7,7 @@ CFLAGS += -pedantic
> CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
> endif
> CFLAGS += -Wdeclaration-after-statement
> +CFLAGS += -Wformat
> CFLAGS += -Wformat-security
> CFLAGS += -Wno-format-zero-length
> CFLAGS += -Wold-style-definition
> --
> 2.20.1.415.g653613c723-goog
>
--
Duy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Specify -Wformat along with -Wformat-security
2018-12-27 18:35 ` Duy Nguyen
@ 2018-12-27 18:46 ` Masaya Suzuki
0 siblings, 0 replies; 3+ messages in thread
From: Masaya Suzuki @ 2018-12-27 18:46 UTC (permalink / raw)
To: Duy Nguyen; +Cc: Git Mailing List
On Thu, Dec 27, 2018 at 10:36 AM Duy Nguyen <pclouds@gmail.com> wrote:
>
> On Thu, Dec 27, 2018 at 7:18 PM Masaya Suzuki <masayasuzuki@google.com> wrote:
> >
> > Without -Wformat, -Wformat-security won't work.
> >
> > > cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
>
> Compiler name and version?
I'm not familar with the tools, so please be patient.
According to Makefile, `CC = cc`. With `cc --version`, it says:
cc (Debian 7.3.0-5) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Jonathan said there was the same patch. Looks like
https://public-inbox.org/git/20181012184037.15076-1-t.gummerer@gmail.com/.
I'll check my config again.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-27 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-27 6:58 [PATCH] Specify -Wformat along with -Wformat-security Masaya Suzuki
2018-12-27 18:35 ` Duy Nguyen
2018-12-27 18:46 ` Masaya Suzuki
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).