From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð" <avarab@gmail.com>,
"Christian Couder" <christian.couder@gmail.com>,
git <git@vger.kernel.org>,
"David Turner" <dturner@twopensource.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH 7/8] config: add core.untrackedCache
Date: Thu, 17 Dec 2015 19:26:45 +0700 [thread overview]
Message-ID: <CACsJy8BwARfGmGBXEdWHnDxxXcubZDzjCg7Zy6qD0qzHZWGoFw@mail.gmail.com> (raw)
In-Reply-To: <20151217074443.GA4830@sigill.intra.peff.net>
On Thu, Dec 17, 2015 at 2:44 PM, Jeff King <peff@peff.net> wrote:
> I think we may actually be thinking of the same thing. Naively, I would
> expect:
>
> ..
> - if there is cache data in the index but that config flag is not set,
> presumably we would not update it (we could even explicitly drop it,
> but my understanding is that is not necessary for correctness, but
> only as a possible optimization).
No, if somebody adds or removes something from the index, we either
update or drop it, or it's stale. There's the invalidate_untracked()
or something in dir.c that we can hook in, check config var and do
that. And because config is cached recently, it should be a cheap
operation.
Apart from that the idea is fine.
> You could have a config option for "if there is a cache there, pretend
> it isn't and ignore it", but I don't see much point.
--
Duy
next prev parent reply other threads:[~2015-12-17 12:27 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 17:15 [PATCH 0/8] Untracked cache improvements Christian Couder
2015-12-08 17:15 ` [PATCH 1/8] update-index: add untracked cache notifications Christian Couder
2015-12-08 19:03 ` Junio C Hamano
2015-12-11 8:51 ` Christian Couder
2015-12-08 17:15 ` [PATCH 2/8] update-index: use enum for untracked cache options Christian Couder
2015-12-08 19:11 ` Junio C Hamano
2015-12-10 10:37 ` Christian Couder
2015-12-10 18:46 ` Junio C Hamano
2015-12-11 9:10 ` Christian Couder
2015-12-11 17:44 ` Junio C Hamano
2015-12-12 9:25 ` Christian Couder
2015-12-08 17:15 ` [PATCH 3/8] update-index: add --test-untracked-cache Christian Couder
2015-12-08 17:15 ` [PATCH 4/8] update-index: move 'uc' var declaration Christian Couder
2015-12-08 17:15 ` [PATCH 5/8] dir: add add_untracked_cache() Christian Couder
2015-12-09 7:37 ` Torsten Bögershausen
2015-12-11 8:54 ` Christian Couder
2015-12-08 17:15 ` [PATCH 6/8] dir: add remove_untracked_cache() Christian Couder
2015-12-08 19:15 ` Junio C Hamano
2015-12-09 7:39 ` Torsten Bögershausen
2015-12-08 17:15 ` [PATCH 7/8] config: add core.untrackedCache Christian Couder
2015-12-08 19:28 ` Junio C Hamano
2015-12-08 22:43 ` Junio C Hamano
2015-12-14 12:18 ` Christian Couder
2015-12-14 19:44 ` Junio C Hamano
2015-12-14 21:30 ` Junio C Hamano
2015-12-15 9:34 ` Christian Couder
2015-12-15 9:49 ` Torsten Bögershausen
2015-12-15 16:42 ` Christian Couder
2015-12-15 10:02 ` Duy Nguyen
2015-12-15 16:35 ` Christian Couder
2015-12-15 13:04 ` Ævar Arnfjörð Bjarmason
2015-12-15 13:42 ` Christian Couder
2015-12-15 19:40 ` Junio C Hamano
2015-12-15 21:53 ` Ævar Arnfjörð Bjarmason
2015-12-15 23:03 ` Junio C Hamano
2015-12-16 1:10 ` Ævar Arnfjörð Bjarmason
2015-12-16 2:46 ` Jeff King
2015-12-16 5:20 ` Junio C Hamano
2015-12-16 6:05 ` Junio C Hamano
2015-12-17 7:44 ` Jeff King
2015-12-17 12:26 ` Duy Nguyen [this message]
[not found] ` <CAP8UFD0S_rWKjWiq_enkN+QVtvnq9fuwAxuuVTXTxu-F1mw4dg@mail.gmail.com>
2015-12-18 22:40 ` Fwd: " Christian Couder
2015-12-21 18:30 ` Junio C Hamano
2015-12-22 8:27 ` Duy Nguyen
2015-12-22 16:33 ` Junio C Hamano
2015-12-24 1:56 ` Junio C Hamano
2015-12-24 9:49 ` Duy Nguyen
2015-12-27 20:21 ` Junio C Hamano
2015-12-24 20:54 ` Christian Couder
[not found] ` <CAP8UFD0LAQG+gQ5EhYYLjo5=tpW3_ah6GV-mgRbgTjjgNmdorA@mail.gmail.com>
2015-12-18 22:38 ` Fwd: " Christian Couder
2015-12-17 12:36 ` Duy Nguyen
2015-12-18 23:24 ` Christian Couder
2015-12-09 13:19 ` Torsten Bögershausen
2015-12-08 17:15 ` [PATCH 8/8] t7063: add tests for core.untrackedCache Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8BwARfGmGBXEdWHnDxxXcubZDzjCg7Zy6qD0qzHZWGoFw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).